fix: avoid shell interpolation in permission dialogs#197
Open
MackDing wants to merge 1 commit into
Open
Conversation
Author
|
Quick follow-up: this PR appears mergeable from my side, and I do not see a failing required check. Happy to make any maintainer-preferred tweak if needed. |
Author
|
Checking in on this PR. The branch is still open, but GitHub is showing an unstable or incomplete status. Please let me know if you want changes from my side, or if this should be rerun/reviewed by maintainers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
os.system(...)permission prompts withsubprocess.run(...)Problem
The permission dialog code interpolated model-generated
codeandaction_descriptioninto shell command strings forosascriptandzenity. That allowed shell metacharacters or broken quoting in the generated action text to execute commands before user approval.Fix
osascriptwith a fixed script and pass the prompt text as an argumentzenitywith argv items instead of a shell stringVerification
python3 -m py_compile gui_agents/s1/cli_app.py gui_agents/s2/cli_app.py gui_agents/s2_5/cli_app.py gui_agents/s3/cli_app.pyCloses #196