Remove Ruby 2.7 deprecation warnings #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onshi
force-pushed
the
fix/remove_ruby_deprecation_warnings
branch
from
27cf364
to
04795e2
Compare
|
Thank you so much for your contribution! BTW, Ruby 2.7.2 has been released and deprecation warnings about keyword argument changes are off by default. Let me consider a little more about this changes for activity_notification. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #122
Summary
This PR fixes all deprecation warnings appearing in specs for ruby 2.7.
(For easier work I also pulled @szechyjs commit into this PR, we should probably merge #137 first and then I will rebase this PR. @simukappu is it okay with you?)