The tracked callback should be implemented using after_commit instead of after_create/after_update

[Looooong]

Whenever notify_later or send_later is enabled in the tracked option on a notifiable, a job is enqueued to be processed. However, in some instance, the job back-end may process the job before the notifiable is persisted in the database. This results in exception on the job back-end.

I suggest that this code:

activity_notification/lib/activity_notification/roles/acts_as_notifiable.rb

Lines 280 to 289 in 07f13c1

	def add_tracked_callback(tracked_callbacks, tracked_action, tracked_proc)
	if tracked_callbacks.include? tracked_action
	case tracked_action
	when :create
	after_create tracked_proc
	when :update
	after_update tracked_proc
	end
	end
	end

should be replaced with:

 def add_tracked_callback(tracked_callbacks, tracked_action, tracked_proc) 
   if tracked_callbacks.include? tracked_action 
     after_commit(tracked_proc, on: tracked_action) 
   end 
 end 

[irondnb]

Totally agree, as after_commit callback ensures that transaction is finished and object persist in database. Im using override in initializer to avoid this problem.

[simukappu]

Can you create a pull request for this?

[Looooong]

I opened #100, but couldn't run the test because of dependency issue. Can you check that out?

[simukappu]

Thank you for your PR. As you mentioned, we have to pass the tests. It seems to be more than just dependency issue.
https://travis-ci.org/simukappu/activity_notification/builds/504662767

[simukappu]

I have fixed this dependency issue for testing in this commit.
For now, it is fixed in master and development branches.

@Looooong, can you check this pull request again?

[simukappu]

Current test result is here: https://travis-ci.org/simukappu/activity_notification/builds/520095237

[Looooong]

@simukappu I have modified the pull requests. And somehow, a few tests only in Rails 5.1 are failed. I wonder if it's Rails specific error?

[irondnb]

@simukappu I have modified the pull requests. And somehow, a few tests only in Rails 5.1 are failed. I wonder if it's Rails specific error?

Actually there was issue with after_commit for 5.1.x. It was fixed on 5.1-stable

rails/rails#30779
rails/rails#32176

[Looooong]

@irondnb Thank you for the information. I couldn't get my head around this. Is there anything we can do to solve this problem?

[simukappu]

@Looooong I avoided this Rails issue with above commit and will merge your PR. Thank you for your contribution!

[simukappu]

Just released as v1.7.1. Thanks!