Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STI and group_owners_only #89

Closed
svarione opened this issue Oct 30, 2018 · 6 comments
Closed

STI and group_owners_only #89

svarione opened this issue Oct 30, 2018 · 6 comments

Comments

@svarione
Copy link

Hello, I's me again ;)! I found a small problem when I use Single Table Inheritance as a group. I solve it by changing the #to_class_name method to self.class.base_class.to_s.

Best regards

@simukappu
Copy link
Owner

Hi, thank you for your feedback :)
Can you point your changing? And, it would be helpful if you create pull request!

@simukappu simukappu added the need more info We need more information label Nov 7, 2018
@simukappu
Copy link
Owner

Hi @svarione, can you provide the detail of you update commit? Perhaps your commit will help other users. Thanks!

@simukappu
Copy link
Owner

Closing this issue for now. Please reopen if required.

@apuntovanini
Copy link

I found same issues as @svarione for STI tables. I guess he meant

this line
Also channels are broken for STI notifiers (or targets, or groups), possibly for the same reason

@simukappu
Copy link
Owner

Reopened to support STI models.

@simukappu
Copy link
Owner

We've just published as v2.1.4.
https://rubygems.org/gems/activity_notification/versions/2.1.4

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants