Skip to content

improvement(subflow): consolidated parallel/loop tags and collaborativeUpdate#931

Merged
waleedlatif1 merged 2 commits intostagingfrom
fix/console
Aug 11, 2025
Merged

improvement(subflow): consolidated parallel/loop tags and collaborativeUpdate#931
waleedlatif1 merged 2 commits intostagingfrom
fix/console

Conversation

@waleedlatif1
Copy link
Collaborator

@waleedlatif1 waleedlatif1 commented Aug 10, 2025

Summary

consolidated parallel/loop tags and collaborativeUpdate

Type of Change

  • improvement

Testing

Tested manually to ensure with two tabs that we update the tags

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Aug 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2025 0:19am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Aug 11, 2025 0:19am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR fixes a bug in the executor's loop handling code by correcting improper property access. The change replaces direct property access this.resolver.loopsByBlockId?.get(block.id) with the proper method call this.resolver.getContainingLoopId(block.id) on line 1525 of apps/sim/executor/index.ts.

This fix ensures the executor uses the intended API for accessing loop information rather than directly accessing internal data structures. The InputResolver class provides the getContainingLoopId() method as the proper interface for retrieving which loop contains a given block ID. Using the method call maintains proper encapsulation, ensures consistent behavior, and prevents potential runtime errors that could occur from accessing undefined properties directly.

The change aligns with the executor's architecture where the resolver acts as the central component for resolving block references and managing loop context, as evidenced by the test code that shows proper interaction patterns between the executor and resolver components.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it fixes a clear API misuse
  • Score reflects a straightforward bug fix that corrects improper property access to use the intended method call
  • No files require special attention as this is a single-line fix with clear intent

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@vercel vercel bot temporarily deployed to Preview – docs August 11, 2025 00:14 Inactive
@waleedlatif1 waleedlatif1 changed the title fix(console): fix typo improvement(subflow): consolidated parallel/loop tags and collaborativeUpdate Aug 11, 2025
@waleedlatif1 waleedlatif1 merged commit df16382 into staging Aug 11, 2025
5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/console branch August 11, 2025 00:19
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…veUpdate (simstudioai#931)

* fix(console): fix typo

* improvement(subflows): consolidated subflows tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant