fix(tag-dropdown): fix values for parallel & loop blocks#929
Merged
waleedlatif1 merged 1 commit intostagingfrom Aug 10, 2025
Merged
fix(tag-dropdown): fix values for parallel & loop blocks#929waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Summary
This PR fixes a bug in the tag dropdown component where contextual variables for loop and parallel blocks (index, currentItem, items) weren't displaying correctly. The issue was caused by the system applying normalized block name prefixes to these special contextual variables, which made them appear incorrectly or not at all in the dropdown interface.
The fix involves two key changes:
- Removal of unnecessary normalized contextual tags: The code previously added entries like
${normalizedLoopBlockName}.resultsto the contextual tags array, which were causing duplication and incorrect display - Special handling for single-word contextual tags: New logic checks if a tag belongs to a loop or parallel block and consists of only one word (like 'index' or 'currentItem'), treating these as standalone variables without block name prefixes
This change integrates well with the existing tag dropdown architecture, which already handles different types of tags (variables, loops, blocks) through various filtering and rendering mechanisms. The fix preserves the existing behavior for regular block output paths that do need prefixes while ensuring contextual variables appear as expected in the workflow editor interface.
Confidence score: 4/5
- This PR is safe to merge with low risk of breaking existing functionality
- Score reflects a targeted bug fix with clear before/after screenshots and good understanding of the contextual variable system
- Pay close attention to the tag filtering logic in lines 802-821 to ensure the conditional handling doesn't affect other block types
1 file reviewed, no comments
waleedlatif1
added a commit
that referenced
this pull request
Aug 10, 2025
waleedlatif1
added a commit
that referenced
this pull request
Aug 11, 2025
…ecution (#928) * standardized response format for transformError * removed trasnformError, moved error handling to executeTool for all different error formats * remove isInternalRoute, make it implicit in executeTool * removed directExecution, everything on the server nothing on the client * fix supabase * fix(tag-dropdown): fix values for parallel & loop blocks (#929) * fix(search-modal): add parallel and loop blocks to search modal * reordered tool params * update docs
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
…ecution (simstudioai#928) * standardized response format for transformError * removed trasnformError, moved error handling to executeTool for all different error formats * remove isInternalRoute, make it implicit in executeTool * removed directExecution, everything on the server nothing on the client * fix supabase * fix(tag-dropdown): fix values for parallel & loop blocks (simstudioai#929) * fix(search-modal): add parallel and loop blocks to search modal * reordered tool params * update docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fix values for parallel & loop blocks, was not showing index and currentItem
Type of Change
Testing
Tested manually
Checklist
Screenshots/Videos
Before:
After:
