Skip to content

improvement(control-bar): standardize styling across all control bar buttons#926

Merged
waleedlatif1 merged 1 commit intostagingfrom
fix/control-bar
Aug 9, 2025
Merged

improvement(control-bar): standardize styling across all control bar buttons#926
waleedlatif1 merged 1 commit intostagingfrom
fix/control-bar

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

standardize styling across all control bar buttons

Type of Change

  • Bug fix

Testing

NA

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Aug 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim 🔄 Building (Inspect) Visit Preview 💬 Add feedback Aug 9, 2025 7:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Aug 9, 2025 7:32pm

@waleedlatif1 waleedlatif1 merged commit 8a08afd into staging Aug 9, 2025
3 of 4 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/control-bar branch August 9, 2025 19:32
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR standardizes the styling across all control bar buttons in the workflow interface by implementing consistent CSS class patterns. The changes affect three key components:

  1. DeploymentControls: Replaces custom HSL color variables (border-[hsl(var(--card-border))] bg-[hsl(var(--card-background))] text-[hsl(var(--card-text))]) with semantic Tailwind CSS classes (border bg-card text-card-foreground) on lines 93 and 98.

  2. ControlBar: Simplifies disabled button styling by removing redundant CSS classes (gap-2, whitespace-nowrap, font-medium, text-sm, ring-offset-background, and SVG selectors) and adding consistent shadow-xs class across delete, duplicate, auto-layout, and publish buttons (lines 415, 500, 564, 723, 774).

  3. ExportControls: Applies the same standardization pattern to the disabled export button state on line 73, removing unnecessary text-related and SVG styling classes while adding shadow-xs for visual consistency.

These changes create a unified visual design system across the control bar by leveraging Tailwind's semantic color tokens instead of custom CSS variables. The standardization improves maintainability by reducing code duplication and ensures all control bar buttons follow the same styling patterns (h-12 w-12 rounded-[11px] border bg-card text-card-foreground shadow-xs). The changes are purely cosmetic and maintain the same visual appearance while making the codebase more consistent and theme-aware.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk as it only involves CSS class standardization without functional changes
  • Score reflects simple styling changes that improve consistency and maintainability without introducing breaking changes
  • No files require special attention as all changes are straightforward CSS class replacements

3 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant