Skip to content

fix(kb-tags): docs page kb tags ui #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 3 commits into from
Aug 1, 2025
Merged

fix(kb-tags): docs page kb tags ui #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96d6e88
fix(kb-tags): docs page kb tags ui
icecrasher321 Aug 1, 2025
5f35102
remove console logs
icecrasher321 Aug 1, 2025
1622f21
remove console error
icecrasher321 Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 2 additions & 36 deletions apps/sim/app/workspace/[workspaceId]/knowledge/[id]/components/upload-modal/upload-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import { Button } from '@/components/ui/button'
import { Dialog, DialogContent, DialogHeader, DialogTitle } from '@/components/ui/dialog'
import { Label } from '@/components/ui/label'
import { createLogger } from '@/lib/logs/console/logger'
import {
type DocumentTag,
DocumentTagEntry,
} from '@/app/workspace/[workspaceId]/knowledge/components/document-tag-entry/document-tag-entry'
import { useKnowledgeUpload } from '@/app/workspace/[workspaceId]/knowledge/hooks/use-knowledge-upload'

const logger = createLogger('UploadModal')
Expand Down Expand Up @@ -50,7 +46,7 @@ export function UploadModal({
}: UploadModalProps) {
const fileInputRef = useRef<HTMLInputElement>(null)
const [files, setFiles] = useState<FileWithPreview[]>([])
const [tags, setTags] = useState<DocumentTag[]>([])

const [fileError, setFileError] = useState<string | null>(null)
const [isDragging, setIsDragging] = useState(false)

Expand All @@ -66,7 +62,6 @@ export function UploadModal({
if (isUploading) return // Prevent closing during upload

setFiles([])
setTags([])
setFileError(null)
setIsDragging(false)
onOpenChange(false)
Expand Down Expand Up @@ -145,23 +140,7 @@ export function UploadModal({
if (files.length === 0) return

try {
// Convert DocumentTag array to TagData format
const tagData: Record<string, string> = {}
tags.forEach((tag) => {
if (tag.value.trim()) {
tagData[tag.slot] = tag.value.trim()
}
})

// Create files with tags for upload
const filesWithTags = files.map((file) => {
// Add tags as custom properties to the file object
const fileWithTags = file as unknown as File & Record<string, string>
Object.assign(fileWithTags, tagData)
return fileWithTags
})

await uploadFiles(filesWithTags, knowledgeBaseId, {
await uploadFiles(files, knowledgeBaseId, {
chunkSize: chunkingConfig?.maxSize || 1024,
minCharactersPerChunk: chunkingConfig?.minSize || 100,
chunkOverlap: chunkingConfig?.overlap || 200,
Expand All @@ -180,19 +159,6 @@ export function UploadModal({
</DialogHeader>

<div className='flex-1 space-y-6 overflow-auto'>
{/* Document Tag Entry Section */}
<DocumentTagEntry
tags={tags}
onTagsChange={setTags}
disabled={isUploading}
knowledgeBaseId={knowledgeBaseId}
documentId={null} // No specific document for upload
onSave={async () => {
// For upload modal, tags are saved when document is uploaded
// This is a placeholder as tags will be applied during upload
}}
/>

{/* File Upload Section */}
<div className='space-y-3'>
<Label>Select Files</Label>
Expand Down
Loading