fix(teams): no immediate acks for ms teams webhook#805
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
There was a problem hiding this comment.
Greptile Summary
This PR removes the special asynchronous processing mechanism for Microsoft Teams webhooks and consolidates all webhook processing through the standard synchronous pathway. Previously, Microsoft Teams webhooks had their own dedicated processMicrosoftTeamsWebhook function that would immediately return an acknowledgment response while executing the workflow asynchronously in the background. This change eliminates that special case and routes all providers (including Teams) through the existing processStandardWebhook function.
The key architectural change is that Microsoft Teams webhooks now execute synchronously like all other webhook providers, meaning the workflow must complete execution before the HTTP response is sent back to Teams. To maintain compatibility with Teams' expected response format, the Teams-specific response structure ({ type: 'message', text: 'Sim Studio' }) has been moved into the standard processor with a provider check.
This change aligns the webhook processing architecture by removing provider-specific execution paths and ensuring consistent error handling, logging, and execution guarantees across all webhook providers. The consolidation simplifies the codebase by eliminating the dual processing paths that existed for Teams versus other providers.
Confidence score: 3/5
- This change could potentially cause timeouts for long-running workflows since Teams webhooks now execute synchronously
- The removal of async processing may impact performance and user experience for Teams integrations
- The
apps/sim/lib/webhooks/utils.tsfile needs careful review to ensure the routing logic and response formatting work correctly
1 file reviewed, no comments
Description
No MS Teams immediate ack mechanism.
Type of change
Checklist:
bun run test)Security Considerations: