improvement(trace-span): make tool calls separately collect in the tracespan #673
Merged
icecrasher321 merged 3 commits intostagingfrom Jul 12, 2025
Merged
improvement(trace-span): make tool calls separately collect in the tracespan #673icecrasher321 merged 3 commits intostagingfrom
icecrasher321 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
PR Summary
Enhanced traceability by modifying how tool calls are collected within trace spans, improving debugging and monitoring capabilities.
- Separates tool calls into individual trace spans for better granularity in tracking and debugging
- Fixed collection mechanism to prevent data mixing between different tool calls
- Added automated testing to verify correct span collection behavior
No files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
✅ No security or compliance issues detected. Reviewed everything up to 6967ac0. Security Overview
Detected Code Changes
Reply to this PR with |
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
…ool-calls improvement(trace-span): make tool calls separately collect in the tracespan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make tool calls separately collect in the trace span. And align model responses with overall duration.
Type of change
How Has This Been Tested?
Screen.Recording.2025-07-12.at.1.56.12.PM.mov
Checklist:
bun run test)Security Considerations: