Skip to content

improvement(trace-span): make tool calls separately collect in the tracespan #673

Merged
icecrasher321 merged 3 commits intostagingfrom
fix/trace-spans-tool-calls
Jul 12, 2025
Merged

improvement(trace-span): make tool calls separately collect in the tracespan #673
icecrasher321 merged 3 commits intostagingfrom
fix/trace-spans-tool-calls

Conversation

@icecrasher321
Copy link
Collaborator

@icecrasher321 icecrasher321 commented Jul 12, 2025

Description

Make tool calls separately collect in the trace span. And align model responses with overall duration.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Screen.Recording.2025-07-12.at.1.56.12.PM.mov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally and in CI (bun run test)
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have updated version numbers as needed (if needed)
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

  • My changes do not introduce any new security vulnerabilities
  • I have considered the security implications of my changes

@vercel
Copy link

vercel bot commented Jul 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sim ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2025 9:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Skipped (Inspect) Jul 12, 2025 9:03pm

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Enhanced traceability by modifying how tool calls are collected within trace spans, improving debugging and monitoring capabilities.

  • Separates tool calls into individual trace spans for better granularity in tracking and debugging
  • Fixed collection mechanism to prevent data mixing between different tool calls
  • Added automated testing to verify correct span collection behavior

No files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@delve-auditor
Copy link

delve-auditor bot commented Jul 12, 2025

No security or compliance issues detected. Reviewed everything up to 6967ac0.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► trace-spans-display.tsx
    Add collapsible input/output sections
    Add tool call data display
► trace-spans.ts
    Enhance execution tracing with sequential segments
    Improve tool call handling
► trace-spans.test.ts
    Add comprehensive test coverage

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@vercel vercel bot temporarily deployed to Preview – docs July 12, 2025 20:59 Inactive
@icecrasher321 icecrasher321 merged commit 4285b36 into staging Jul 12, 2025
6 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/trace-spans-tool-calls branch July 14, 2025 21:21
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…ool-calls

improvement(trace-span): make tool calls separately collect in the tracespan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant