fix(6s-timeout): 6 seconds timeout for sockets server warning #645
Merged
icecrasher321 merged 1 commit intostagingfrom Jul 9, 2025
Merged
fix(6s-timeout): 6 seconds timeout for sockets server warning #645icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Implements a 6-second delay before showing offline mode warning in socket disconnections to prevent false positives from brief network interruptions.
- Modified
apps/sim/app/workspace/[workspaceId]/w/components/providers/workspace-permissions-provider.tsxto include a 6-secondsetTimeoutbefore triggering the offline warning - Added cleanup function to prevent memory leaks from timeout handlers
- Maintains existing requirement for page refresh to restore edit permissions after disconnection
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Comment on lines
+90
to
+93
| const timeoutId = setTimeout(() => { | ||
| setIsOfflineMode(true) | ||
| }, 6000) | ||
| return () => clearTimeout(timeoutId) |
Contributor
There was a problem hiding this comment.
style: Consider extracting timeout duration (6000) to a named constant at the top of the file for better maintainability
|
✅ No security or compliance issues detected. Reviewed everything up to 4e679af. Security Overview
Detected Code Changes
Reply to this PR with |
arenadeveloper02
pushed a commit
to arenadeveloper02/p2-sim
that referenced
this pull request
Sep 19, 2025
Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only show warning after 6 seconds after disconnection.
Type of change
Checklist:
bun run test)Security Considerations: