Skip to content

fix(frozen canvas): don't error if workflow state not available for migrated logs #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 2 commits into from
Jul 7, 2025
Merged

fix(frozen canvas): don't error if workflow state not available for migrated logs #624

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
823a60f
fix(frozen canvas): don't error if workflow state not available for o…
Jul 7, 2025
4b84ba7
fix lint
Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 19 additions & 16 deletions apps/sim/app/workspace/[workspaceId]/logs/logs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,15 +305,18 @@ export default function Logs() {
<div className='flex flex-1 flex-col overflow-hidden'>
{/* Table container */}
<div className='flex flex-1 flex-col overflow-hidden'>
{/* Simple header */}
<div className='border-border/50 border-b px-4 py-3'>
<div className='flex items-center gap-4 font-medium text-muted-foreground text-xs'>
<div className='w-32'>Time</div>
<div className='w-20'>Status</div>
<div className='flex-1'>Workflow</div>
<div className='hidden w-24 lg:block'>Trigger</div>
<div className='hidden w-20 xl:block'>Cost</div>
<div className='w-20'>Duration</div>
{/* Table with fixed layout */}
<div className='w-full min-w-[800px]'>
{/* Header */}
<div className='border-border/50 border-b'>
<div className='grid grid-cols-[160px_100px_1fr_120px_100px_100px] gap-4 px-4 py-3 font-medium text-muted-foreground text-xs'>
<div>Time</div>
<div>Status</div>
<div>Workflow</div>
<div className='hidden lg:block'>Trigger</div>
<div className='hidden xl:block'>Cost</div>
<div>Duration</div>
</div>
</div>
</div>

Expand Down Expand Up @@ -357,17 +360,17 @@ export default function Logs() {
}`}
onClick={() => handleLogClick(log)}
>
<div className='flex items-center gap-4 p-4'>
<div className='grid grid-cols-[160px_100px_1fr_120px_100px_100px] gap-4 p-4'>
{/* Time */}
<div className='w-32 flex-shrink-0'>
<div>
<div className='font-medium text-sm'>{formattedDate.formatted}</div>
<div className='text-muted-foreground text-xs'>
{formattedDate.relative}
</div>
</div>

{/* Status */}
<div className='w-20 flex-shrink-0'>
<div>
<div
className={`inline-flex items-center justify-center rounded-md px-2 py-1 text-xs ${
log.level === 'error'
Expand All @@ -382,7 +385,7 @@ export default function Logs() {
</div>

{/* Workflow */}
<div className='min-w-0 flex-1'>
<div className='min-w-0'>
<div className='truncate font-medium text-sm'>
{log.workflow?.name || 'Unknown Workflow'}
</div>
Expand All @@ -392,14 +395,14 @@ export default function Logs() {
</div>

{/* Trigger */}
<div className='hidden w-24 flex-shrink-0 lg:block'>
<div className='hidden lg:block'>
<div className='text-muted-foreground text-xs'>
{log.trigger || '—'}
</div>
</div>

{/* Cost */}
<div className='hidden w-20 flex-shrink-0 xl:block'>
<div className='hidden xl:block'>
<div className='text-xs'>
{log.metadata?.enhanced && log.metadata?.cost?.total ? (
<span className='text-muted-foreground'>
Expand All @@ -412,7 +415,7 @@ export default function Logs() {
</div>

{/* Duration */}
<div className='w-20 flex-shrink-0'>
<div>
<div className='text-muted-foreground text-xs'>
{log.duration || '—'}
</div>
Expand Down
26 changes: 21 additions & 5 deletions apps/sim/app/workspace/[workspaceId]/w/components/workflow-preview/workflow-preview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@ export function WorkflowPreview({
defaultZoom,
onNodeClick,
}: WorkflowPreviewProps) {
// Handle migrated logs that don't have complete workflow state
if (!workflowState || !workflowState.blocks || !workflowState.edges) {
return (
<div
style={{ height, width }}
className='flex items-center justify-center rounded-lg border border-gray-200 bg-gray-50 dark:border-gray-700 dark:bg-gray-900'
>
<div className='text-center text-gray-500 dark:text-gray-400'>
<div className='mb-2 font-medium text-lg'>⚠️ Logged State Not Found</div>
<div className='text-sm'>
This log was migrated from the old system and doesn't contain workflow state data.
</div>
</div>
</div>
)
}
const blocksStructure = useMemo(
() => ({
count: Object.keys(workflowState.blocks || {}).length,
Expand All @@ -84,8 +100,8 @@ export function WorkflowPreview({

const edgesStructure = useMemo(
() => ({
count: workflowState.edges.length,
ids: workflowState.edges.map((e) => e.id).join(','),
count: workflowState.edges?.length || 0,
ids: workflowState.edges?.map((e) => e.id).join(',') || '',
}),
[workflowState.edges]
)
Expand Down Expand Up @@ -115,7 +131,7 @@ export function WorkflowPreview({
const nodes: Node[] = useMemo(() => {
const nodeArray: Node[] = []

Object.entries(workflowState.blocks).forEach(([blockId, block]) => {
Object.entries(workflowState.blocks || {}).forEach(([blockId, block]) => {
if (!block || !block.type) {
logger.warn(`Skipping invalid block: ${blockId}`)
return
Expand Down Expand Up @@ -186,7 +202,7 @@ export function WorkflowPreview({
})

if (block.type === 'loop') {
const childBlocks = Object.entries(workflowState.blocks).filter(
const childBlocks = Object.entries(workflowState.blocks || {}).filter(
([_, childBlock]) => childBlock.data?.parentId === blockId
)

Expand Down Expand Up @@ -223,7 +239,7 @@ export function WorkflowPreview({
}, [blocksStructure, loopsStructure, parallelsStructure, showSubBlocks, workflowState.blocks])

const edges: Edge[] = useMemo(() => {
return workflowState.edges.map((edge) => ({
return (workflowState.edges || []).map((edge) => ({
id: edge.id,
source: edge.source,
target: edge.target,
Expand Down