v0.2.6: fix + feat + improvement by icecrasher321 · Pull Request #612 · simstudioai/sim

icecrasher321 · 2025-07-03T19:53:01Z

Description

Changelog:

More granular logging for func execution
Temp Controls for 4.1 series of models
Executor Dep Resolution Fix
Create Workflow Cleanup + Race condition Fix + New naming + colors system for workflows
KB Uploads Fix
Migrations of Usage Billing + upcoming logging system
Telegram markdown rendering fix
Remove before unload warning

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Performance improvement
Code refactoring (no functional changes)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added tests that prove my fix is effective or that my feature works
All tests pass locally and in CI (bun run test)
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules
I have updated version numbers as needed (if needed)
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Security Considerations:

My changes do not introduce any new security vulnerabilities
I have considered the security implications of my changes

… for easier debugging (#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting

* improvement: added knowledge upload * improvement: added greptile comments (#579) * improvement: changed to text to doc (#579) * improvement: removed comment (#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com>

…olumn in any routes (#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com>

Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

…#597)

…inputs to execute (#598)

* feat(billing): added migrations for usage-based billing * lint * lint

* feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net>

) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

* fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

* fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com>

vercel · 2025-07-03T19:53:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sim (staging)	🔄 Building (Inspect)			Jul 3, 2025 7:53pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
docs	⬜️ Skipped (Inspect)			Jul 3, 2025 7:53pm

delve-auditor · 2025-07-03T19:53:34Z

✅ No security or compliance issues detected. Reviewed everything up to ce0a71d.

Security Overview

🔎 Scanned files: 57 changed file(s)

Detected Code Changes

Change Type	Relevant files
Bug Fix	► KB Upload Logic Fix and consolidate KB file uploads logic Consolidate presigned routes Fix temporary ID KB store issue
Enhancement	► Edit Chunk Modal Added navigation to next/previous chunk

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

greptile-apps

PR Summary

Major architectural improvements focusing on normalized database tables, improved error handling, and enhanced logging systems for workflow execution.

Replaced monolithic workflow state with normalized tables (workflowExecutionBlocks, workflowExecutionLogs, workflowExecutionSnapshots) in apps/sim/db/migrations/0049_fancy_cardiac.sql for better performance and maintainability
Enhanced function execution error reporting with line numbers and context in apps/sim/tools/function/execute.ts
Added temperature controls (0-2 range) for GPT-4.1 series models in apps/sim/providers/models.ts
Implemented comprehensive usage tracking and billing system with new columns in apps/sim/db/migrations/0048_flawless_ultron.sql
Added document creation capabilities to knowledge base with new knowledgeCreateDocumentTool in apps/sim/tools/knowledge/create_document.ts

_{56 files reviewed, 42 comments}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-07-03T19:53:26Z

apps/sim/app/api/workspaces/route.ts

        folderId: null,
-        name: 'Workflow 1',
+        name: 'default-agent',
        description: 'Your first workflow - start building here!',


style: Description still references 'first workflow' which doesn't match the new 'default-agent' name convention

greptile-apps · 2025-07-03T19:53:28Z

apps/sim/tools/function/execute.test.ts

+    test('should handle enhanced runtime error with line and column', async () => {
+      // Setup enhanced runtime error response
+      tester.setup(
+        {
+          success: false,
+          error:
+            "Type Error: Line 2:16: `return obj.someMethod();` - Cannot read properties of null (reading 'someMethod')",
+          output: {
+            result: null,
+            stdout: 'ERROR: {}\n',
+            executionTime: 12,
+          },
+          debug: {
+            line: 2,
+            column: 16,
+            errorType: 'TypeError',
+            lineContent: 'return obj.someMethod();',
+            stack: 'TypeError: Cannot read properties of null...',
+          },
+        },
+        { ok: false, status: 500 }
+      )
+
+      // Execute the tool with runtime error
+      const result = await tester.execute({
+        code: 'const obj = null;\nreturn obj.someMethod();',
+      })
+
+      // Check enhanced error handling
+      expect(result.success).toBe(false)
+      expect(result.error).toContain('Type Error')
+      expect(result.error).toContain('Line 2:16')
+      expect(result.error).toContain('return obj.someMethod();')
+      expect(result.error).toContain('Cannot read properties of null')
+    })


style: Consider extracting the test setup into a shared helper function since similar setup patterns are repeated across multiple tests

greptile-apps · 2025-07-03T19:53:28Z

apps/docs/content/docs/tools/knowledge.mdx

+| `knowledgeBaseId` | string | Yes | ID of the knowledge base containing the document |
+| `name` | string | Yes | Name of the document |
+| `content` | string | Yes | Content of the document |


style: knowledgeBaseId parameter description should clarify whether this is for new or existing knowledge bases

greptile-apps · 2025-07-03T19:53:28Z

apps/sim/db/migrations/0048_flawless_ultron.sql

+ALTER TABLE "user_stats" ADD COLUMN "usage_limit_updated_at" timestamp DEFAULT now();--> statement-breakpoint
+ALTER TABLE "user_stats" ADD COLUMN "current_period_cost" numeric DEFAULT '0' NOT NULL;--> statement-breakpoint
+ALTER TABLE "user_stats" ADD COLUMN "billing_period_start" timestamp DEFAULT now();--> statement-breakpoint
+ALTER TABLE "user_stats" ADD COLUMN "billing_period_end" timestamp;--> statement-breakpoint


logic: billing_period_end allows NULL but billing_period_start doesn't. Consider if both should require values for data consistency.

greptile-apps · 2025-07-03T19:53:29Z

apps/docs/content/docs/tools/knowledge.mdx

+| `data` | string |
+| `name` | string |


logic: Output parameters 'data' and 'name' need more detailed type specifications and descriptions

greptile-apps · 2025-07-03T19:53:38Z

apps/sim/app/api/workflows/[id]/execute/route.test.ts

+    // Mock normalized tables helper for this specific test
+    vi.doMock('@/lib/workflows/db-helpers', () => ({
+      loadWorkflowFromNormalizedTables: vi.fn().mockResolvedValue({
+        blocks: {
+          'starter-id': {
+            id: 'starter-id',
+            type: 'starter',
+            name: 'Start',
+            position: { x: 100, y: 100 },
+            enabled: true,
+            subBlocks: {},
+            outputs: {},
+            data: {},
+          },
+          'agent-id': {
+            id: 'agent-id',
+            type: 'agent',
+            name: 'Agent',
+            position: { x: 300, y: 100 },
+            enabled: true,
+            subBlocks: {},
+            outputs: {},
+            data: {},
+          },
+        },
+        edges: [
+          {
+            id: 'edge-1',
+            source: 'starter-id',
+            target: 'agent-id',
+            sourceHandle: 'source',
+            targetHandle: 'target',
+          },
+        ],
+        loops: {},
+        parallels: {},
+        isFromNormalizedTables: true,
+      }),
+    }))


style: Duplicate mock definition of loadWorkflowFromNormalizedTables. Extract into a shared test helper to maintain DRY principle

greptile-apps · 2025-07-03T19:53:38Z

apps/sim/tools/knowledge/create_document.ts

+        processingOptions: {
+          chunkSize: 1024,
+          minCharactersPerChunk: 100,
+          chunkOverlap: 200,
+          recipe: 'default',
+          lang: 'en',
+        },


style: Processing options should be extracted to a config file rather than hardcoded in the component

greptile-apps · 2025-07-03T19:53:39Z

apps/sim/tools/knowledge/create_document.ts

+      const utf8Bytes = new TextEncoder().encode(textContent)
+      const base64Content =
+        typeof Buffer !== 'undefined'
+          ? Buffer.from(textContent, 'utf8').toString('base64')
+          : btoa(String.fromCharCode(...utf8Bytes))
+


style: Redundant encoding - TextEncoder is already used for contentBytes. Can reuse utf8Bytes for Buffer.from

greptile-apps · 2025-07-03T19:53:39Z

apps/sim/tools/knowledge/create_document.ts

+          documentId: firstDocument?.documentId || firstDocument?.id || '',
+        },
+      }
+    } catch (error: any) {


style: Avoid using 'any' type for error. Consider using Error | unknown

Suggested change

} catch (error: any) {

} catch (error: Error | unknown) {

greptile-apps · 2025-07-03T19:53:42Z

apps/sim/db/migrations/meta/0049_snapshot.json

+      "checkConstraints": {
+        "check_enterprise_metadata": {
+          "name": "check_enterprise_metadata",
+          "value": "plan != 'enterprise' OR (metadata IS NOT NULL AND (metadata->>'perSeatAllowance' IS NOT NULL OR metadata->>'totalAllowance' IS NOT NULL))"
+        }


logic: Subscription plan constraint requires either perSeatAllowance or totalAllowance for enterprise plans, ensure this is handled in application code

* feat(function): added more granular error logs for function execution for easier debugging (simstudioai#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting * feat(models): added temp controls for gpt-4.1 family of models (simstudioai#594) * improvement(knowledge-upload): create and upload document to KB (simstudioai#579) * improvement: added knowledge upload * improvement: added greptile comments (simstudioai#579) * improvement: changed to text to doc (simstudioai#579) * improvement: removed comment (simstudioai#579) * added input validation, tested persistence of KB selector * update docs --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(remove workflow.state usage): no more usage of deprecated state column in any routes (simstudioai#586) * fix(remove workflow.state usage): no more usage of deprecated state col in routes * fix lint * fix chat route to only use deployed state * fix lint * better typing * remove useless logs * fix lint * restore workflow handler file * removed all other usages of deprecated 'state' column from workflows table, updated tests --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Waleed Latif <walif6@gmail.com> * fix(doc-selector-kb): enable doc selector when kb is selected (simstudioai#596) Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> * fix(unload): remove beforeunload warning since we communicate via wss (simstudioai#597) * fix(executor): fix dependency resolution, allow blocks with multiple inputs to execute (simstudioai#598) * feat(billing): added migrations for usage-based billing (simstudioai#601) * feat(billing): added migrations for usage-based billing * lint * lint * feat(logging): add new schemas + types for new logging system (simstudioai#599) * feat(logging): add new schemas + types for logging * fix lint * update migration * fix lint * Remove migration 48 to avoid conflict with staging * fixed merge conflict * fix lint --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> * fix(createWorkflow): cleanup create workflow to prevent re-renders (simstudioai#607) * fix(createWorkflow): no more client side id, duplicate schedules calls * fix lint * more cleanup * fix lint * fix spamming of create button causing issues * fix lint * add more colors + default workflow name changed * Update apps/sim/stores/workflows/registry/utils.ts Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> * fix(telegram): added markdown text rendering (simstudioai#611) * fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local> * fix(kb-upload): fix and consolidate KB file uploads logic (simstudioai#610) * fix(kb-upload): fix and consolidate logic * fix lint * consolidated presigned routes, fixed temp id kb store issue, added nav to next/prev chunk on edit chunk modal * fix ci test --------- Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Waleed Latif <walif6@gmail.com> --------- Co-authored-by: Waleed Latif <walif6@gmail.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-MacBook-Air.local> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan> Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@Vikhyaths-Air.attlocal.net> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

waleedlatif1 and others added 12 commits June 30, 2025 18:12

feat(function): added more granular error logs for function execution…

e4141e9

… for easier debugging (#593) * added more granular error logs for function execution * added tests * fixed syntax error reporting

feat(models): added temp controls for gpt-4.1 family of models (#594)

24cb3ac

fix(doc-selector-kb): enable doc selector when kb is selected (#596)

acb4e57

Co-authored-by: Vikhyath Mondreti <vikhyathmondreti@vikhyaths-air.lan>

fix(unload): remove beforeunload warning since we communicate via wss (…

901d20d

…#597)

fix(executor): fix dependency resolution, allow blocks with multiple …

9aff331

…inputs to execute (#598)

feat(billing): added migrations for usage-based billing (#601)

7a5c407

* feat(billing): added migrations for usage-based billing * lint * lint

fix(telegram): added markdown text rendering (#611)

bf98c50

* fix: added proper markdown * fix: reverted route.ts file --------- Co-authored-by: Adam Gough <adamgough@Adams-MacBook-Pro.local>

icecrasher321 merged commit 016cd67 into main Jul 3, 2025
4 of 7 checks passed

greptile-apps bot reviewed Jul 3, 2025

View reviewed changes

vercel bot deployed to staging – sim July 3, 2025 19:57 View deployment

Conversation

icecrasher321 commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Security Considerations:

Uh oh!

vercel bot commented Jul 3, 2025

Uh oh!

Uh oh!

delve-auditor bot commented Jul 3, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

icecrasher321 commented Jul 3, 2025 •

edited

Loading