fix(search-chunk): searchbar in knowledge base chunk#557
fix(search-chunk): searchbar in knowledge base chunk#557waleedlatif1 merged 7 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
✅ No security or compliance issues detected. Reviewed everything up to 1c051d1. Security Overview
Detected Code Changes
Reply to this PR with |
There was a problem hiding this comment.
PR Summary
Implements robust search functionality in the knowledge base chunk viewer with improved state management and user experience.
- Added debounced search with loading states in
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx - Implemented URL-based state persistence for search queries and pagination
- Added page position restoration after search clear
- Enhanced error handling for document processing status
- Improved loading state management during search operations
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
PR Summary
Fixed search functionality implementation in knowledge base chunk viewer with enhanced state management and error handling.
- Fixed issue with search state clearing by properly handling URL state reset in
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx - Added proper dependency management in useEffect hooks to prevent stale closures
- Implemented consistent error state handling during search operations
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
463b669 to
2462b2a
Compare
waleedlatif1
left a comment
There was a problem hiding this comment.
we have to consider moving the searching for chunks server-side, since loading in 100+ chunks all at once and filtering on the client-side might cause bad performance and errors. just have to weigh the options but this is not a good implementation
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
Outdated
Show resolved
Hide resolved
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
Outdated
Show resolved
Hide resolved
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/[documentId]/document.tsx
Outdated
Show resolved
Hide resolved
dd2ccdd to
805b245
Compare
|
Can you remove the commits not related to this PR and rebase? |
3f3284e to
be69790
Compare
be69790 to
73822ad
Compare
6e10c79 to
0bf9ce0
Compare
c7e96e3 to
125a93e
Compare
125a93e to
0afe3e2
Compare
There was a problem hiding this comment.
PR Summary
Comprehensive refactoring to simplify block output structures and improve knowledge base search functionality across the codebase.
- Flattened response objects across all block types, removing nested 'response' wrappers for simpler data access
- Added realtime server with Socket.IO for collaborative features, including proper CORS and authentication handling
- Enhanced error handling in function execution with detailed line numbers and context
- Improved token refresh mechanism and OAuth provider configurations for better reliability
- Added auto-pan setting with proper database migration and UI controls
254 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
0afe3e2 to
1c051d1
Compare
* fix: chunk search bar fix * fix: fixed reload and refresh * fix: fixed structure * fix: need to fix persisting in knowledge search * fix: adding page as query param * fix: bun run lint (simstudioai#557) * added instantaneous client-side search, added fuzzy search & text highlighting --------- Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net> Co-authored-by: Waleed Latif <walif6@gmail.com>
Description
The search bar in the knowledge base for the chunks wasn't working, now it is so users can search chunks.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Searched a chunk, removed the search query, refreshed the page, clicked through the pages and confirmed that all of this was working.
Checklist:
bun run test)Security Considerations: