fix(serializer): validate required fields for blocks without tools

[waleedlatif1]

Summary

• Fixed serializer skipping required field validation for blocks with empty tools.access (e.g., wait block)
• Added validation loop for subBlock required fields not covered by tool params
• Minor fix for duration formatting to show "0ms" instead of "0.00ms"

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

^{Cursor Bugbot found 1 potential issue for commit 60fcaf5}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Feb 4, 2026 11:47pm

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed serializer validation bug where required fields were not validated for blocks with empty tools.access arrays (like wait blocks).

The previous implementation early-returned when tools.access was empty, skipping validation entirely. The fix restructures the validation logic:

• First validates tool parameters for blocks that have tools
• Then validates required subBlock fields not already covered by tool params
• Uses a Set to track which fields were already validated to avoid duplication

Also includes a minor formatting improvement to show "0ms" instead of "0.00ms" for zero/near-zero durations.

Key changes:

• Moved tool existence check inside validation section rather than early return
• Added secondary validation loop for subBlocks with required: true not covered by tool params
• Added comprehensive test coverage for wait block validation scenarios
• Tests cover: missing required fields, valid fields, multiple missing fields, and disabled block handling

Confidence Score: 4/5

• This PR is safe to merge with minimal risk
• The changes fix a clear bug in validation logic with comprehensive test coverage. The refactoring is well-structured and maintains backward compatibility for blocks with tools. Minor deduction for lack of integration testing across different block types with varying tool configurations.
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/serializer/index.ts	Refactored validation logic to handle blocks without tools by adding secondary validation loop for required subBlock fields not covered by tool params
apps/sim/serializer/index.test.ts	Added comprehensive test coverage for wait block validation with empty tools.access array

Sequence Diagram

sequenceDiagram
    participant Client
    participant Serializer
    participant ValidationLogic
    participant BlockConfig
    participant ToolRegistry
    
    Client->>Serializer: serializeWorkflow(blocks, validateRequired=true)
    Serializer->>Serializer: serializeBlock(block)
    Serializer->>Serializer: extractParams(block)
    
    alt validateRequired is true
        Serializer->>ValidationLogic: validateRequiredFieldsBeforeExecution(block, blockConfig, params)
        
        ValidationLogic->>BlockConfig: Check if block enabled
        
        alt Block has tools.access
            ValidationLogic->>ToolRegistry: getTool(currentToolId)
            ToolRegistry-->>ValidationLogic: currentTool
            
            loop For each tool param
                ValidationLogic->>ValidationLogic: Check if required & user-only
                ValidationLogic->>ValidationLogic: Check visibility via shouldSerializeSubBlock
                ValidationLogic->>ValidationLogic: Validate field value
            end
        end
        
        Note over ValidationLogic: NEW: Secondary validation for blocks without tools
        
        ValidationLogic->>ValidationLogic: Build validatedByTool Set
        
        loop For each subBlock in blockConfig
            alt Not validated by tool params
                ValidationLogic->>ValidationLogic: Check visibility via shouldSerializeSubBlock
                ValidationLogic->>ValidationLogic: Check if required
                ValidationLogic->>ValidationLogic: Validate field value
            end
        end
        
        alt Missing fields found
            ValidationLogic-->>Serializer: throw Error(missing fields)
            Serializer-->>Client: Error
        else All fields valid
            ValidationLogic-->>Serializer: validation passed
        end
    end
    
    Serializer->>Serializer: Continue serialization
    Serializer-->>Client: SerializedBlock

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}