fix(agent-logs): don't filter out any agent outputs from trace span#3086
Merged
icecrasher321 merged 1 commit intostagingfrom Jan 30, 2026
Merged
fix(agent-logs): don't filter out any agent outputs from trace span#3086icecrasher321 merged 1 commit intostagingfrom
icecrasher321 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryRemoved Key changes:
Impact:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Executor
participant AgentBlock
participant OutputFilter
participant TraceSpans
participant Display
Note over AgentBlock: PR Change: Remove hiddenFromDisplay flags
Executor->>AgentBlock: Execute agent block
AgentBlock->>AgentBlock: Generate outputs (content, cost, providerTiming)
AgentBlock-->>Executor: Return all outputs
Executor->>OutputFilter: filterOutputForLog(blockType, output)
alt Before PR
OutputFilter->>OutputFilter: Check hiddenFromDisplay flag
OutputFilter->>OutputFilter: Filter out cost & providerTiming
OutputFilter-->>Executor: Filtered output (no cost/providerTiming)
else After PR
OutputFilter->>OutputFilter: Check hiddenFromDisplay flag
OutputFilter->>OutputFilter: Include all outputs
OutputFilter-->>Executor: Complete output (with cost/providerTiming)
end
Executor->>TraceSpans: buildTraceSpans(executionResult)
alt After PR
TraceSpans->>TraceSpans: Extract log.output.providerTiming
TraceSpans->>TraceSpans: Extract log.output.cost
TraceSpans->>TraceSpans: Add to span.providerTiming
TraceSpans->>TraceSpans: Add to span.cost
end
TraceSpans-->>Display: TraceSpan with cost & timing data
Display->>Display: Display cost & timing in UI
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not filter out any agent outputs from trace spans.
Type of Change
Testing
Tested manually
Checklist