fix(type): logs workspace delivery

[icecrasher321]

Summary

Workspace notif delivery

Type of Change

• Bug fix

Testing

Ran typecheck

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Jan 29, 2026 3:49am

[greptile-apps]

Greptile Overview

Greptile Summary

Added null-safety handling for notification delivery when workflows are deleted.

• Added early return in buildPayload when log.workflowId is null to prevent database query errors
• Added null payload check in executeNotificationDelivery to gracefully handle deleted workflows
• Delivery is marked as failed with message "Workflow was deleted" when workflow no longer exists

The changes properly handle the edge case where a workflow execution log exists but the workflow itself has been deleted, preventing potential crashes or unhandled errors in the notification delivery system.

Confidence Score: 4/5

• This PR is safe to merge with minimal risk - it adds defensive null-checking for an edge case
• The changes are focused and defensive, properly handling a specific edge case where workflows are deleted but notification deliveries still exist. The implementation follows good error handling patterns by checking for null early, marking the delivery as failed, and logging the event. The type signature change accurately reflects the new return possibility.
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/background/workspace-notification-delivery.ts	Added null check for deleted workflows to prevent notification delivery errors

Sequence Diagram

sequenceDiagram
    participant ED as executeNotificationDelivery
    participant BP as buildPayload
    participant DB as Database
    participant UD as updateDeliveryStatus
    
    ED->>DB: Fetch subscription
    alt Subscription not found or inactive
        ED->>UD: Mark as failed
        ED->>ED: Return early
    end
    
    ED->>DB: Claim delivery (update to in_progress)
    alt Not claimable
        ED->>ED: Return early
    end
    
    ED->>BP: buildPayload(log, subscription)
    
    alt log.workflowId is null
        BP->>BP: Return null (deleted workflow)
        BP-->>ED: null
        ED->>UD: Mark as failed ("Workflow was deleted")
        ED->>ED: Return early
    else log.workflowId exists
        BP->>DB: Query workflow data
        BP->>BP: Build notification payload
        BP-->>ED: NotificationPayload
        
        alt Delivery succeeds
            ED->>UD: Mark as success
        else Delivery fails and attempts < MAX_ATTEMPTS
            ED->>UD: Mark as pending with nextAttemptAt
        else Delivery fails and attempts >= MAX_ATTEMPTS
            ED->>UD: Mark as failed
        end
    end

Loading

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}