feat(helm): add branding configmap for custom assets#3008
Merged
waleedlatif1 merged 1 commit intostagingfrom Jan 26, 2026
Merged
feat(helm): add branding configmap for custom assets#3008waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1 merged 1 commit intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR adds a branding ConfigMap feature that enables users to inject custom logos, CSS, and other assets into the Sim application. The implementation follows established Helm patterns from the codebase and provides a clean interface for mounting both text and binary files. Key Changes:
Implementation Quality:
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as Helm User
participant Values as values.yaml
participant CM as ConfigMap Template
participant Deploy as Deployment Template
participant K8s as Kubernetes
participant App as App Container
User->>Values: Set branding.enabled=true
User->>Values: Define branding.files & binaryFiles
User->>Values: Set branding.mountPath (optional)
alt branding.enabled == true
CM->>K8s: Create ConfigMap with data/binaryData
Deploy->>K8s: Add branding volume to Deployment
Deploy->>K8s: Add branding volumeMount to container
K8s->>App: Mount ConfigMap at /app/public/branding
App->>App: Branding assets available in public directory
else branding.enabled == false
CM-->>K8s: ConfigMap not created
Deploy-->>K8s: No branding volume added
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/app/public/brandingwhen enabledfiles) and binary files (binaryFiles) via base64Type of Change
Testing
Tested with
helm templateandhelm lint- both passChecklist