fix(jina): removed conditionally included outputs from jina#2559
fix(jina): removed conditionally included outputs from jina#2559waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryRemoved
Note: This PR also includes two unrelated changes: a whitespace addition in Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant JinaBlock
participant readUrlTool
participant JinaAPI
participant Response
User->>JinaBlock: Configure read_url operation
Note over User,JinaBlock: Set url, options (gatherLinks, withImagesummary, etc)
JinaBlock->>readUrlTool: Execute with params
readUrlTool->>readUrlTool: Build request headers
Note over readUrlTool: Add X-With-Links-Summary, X-With-Images-Summary<br/>based on user options
readUrlTool->>JinaAPI: GET https://r.jina.ai/{url}
Note over readUrlTool,JinaAPI: Headers include API key, options
JinaAPI-->>readUrlTool: Response (content, links?, images?)
Note over JinaAPI,readUrlTool: links/images only present when<br/>specific options enabled
readUrlTool->>readUrlTool: transformResponse()
Note over readUrlTool: BEFORE: Extract links & images<br/>AFTER: Only extract content
readUrlTool-->>JinaBlock: Return {content}
Note over readUrlTool,JinaBlock: Removed conditionally present fields
JinaBlock-->>User: Display available outputs
Note over JinaBlock,User: Only 'content' shown in dropdown<br/>(no misleading links/images)
|
There was a problem hiding this comment.
Additional Comments (2)
-
apps/sim/tools/jina/read_url.ts, line 171-172 (link)logic:
linksandimagesare still included in the response object but no longer defined in theoutputsschema. This creates inconsistency - the data is returned but won't be visible in tag dropdowns. Either remove these fields entirely fromtransformResponseor keep them in theoutputsschema. -
apps/sim/tools/jina/types.ts, line 28-29 (link)logic: Type definition still includes
linksandimagesas optional fields but theoutputsschema no longer declares them. This creates a type/runtime mismatch. Should remove these from the type definition to maintain consistency with the outputs schema.
10 files reviewed, 2 comments
|
@greptile |
Summary
imagesandlinksare only sometimes included, misleading to always show them in the tag dropdownType of Change
Testing
Tested manually
Checklist