fix(condition): fixed deactivated edges when if and else if conditions connected to same destination block, added 100+ unit tests

[waleedlatif1]

Summary

• fixed deactivated edges when if and else if conditions connected to same destination block
• added 100+ unit tests

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Dec 20, 2025 5:06am

[greptile-apps]

Greptile Summary

Fixed a critical bug where multiple condition branches (if/else if/else) pointing to the same destination block would incorrectly deactivate that block and its descendants. The root cause was twofold:

Core Issues Fixed:

• Edge ID collision in edges.ts: Multiple edges from same source to same target would overwrite each other because edge IDs didn't include the sourceHandle suffix
• Premature cascade deactivation in edge-manager.ts: When deactivating non-selected branches, the system would incorrectly cascade-deactivate shared destination blocks that still had active incoming edges from selected branches

Technical Changes:

• Modified edge ID generation to include sourceHandle suffix: ${sourceId}→${targetId}-${sourceHandle}
• Refactored processOutgoingEdges to use a 4-pass algorithm that defers deactivation checks until after edge categorization
• Updated hasActiveIncomingEdges to accept specific edge keys instead of just source IDs, properly handling multiple edges from same source
• Removed verbose logging and cleaned up unused parameters in condition handler

Test Coverage:
Added 1,900+ lines of unit tests across 3 test files covering:

• Edge ID uniqueness for multiple branches to same target
• If→A, else if→B, else→A patterns
• Sequential condition evaluation with various data types
• Complex workflow scenarios with branching and merging
• Edge activation and deactivation logic

Confidence Score: 5/5

• This PR is safe to merge with high confidence
• The fix addresses a well-defined bug with clear root cause analysis. The implementation is elegant (4-pass algorithm) and properly handles edge cases. Most importantly, 1,900+ lines of comprehensive unit tests were added, providing excellent coverage of the bug scenarios and preventing regressions.
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/executor/dag/construction/edges.ts	Fixed edge ID generation to include sourceHandle suffix, preventing duplicate edges from same source to same target from overwriting each other
apps/sim/executor/execution/edge-manager.ts	Refactored edge processing to use 4-pass algorithm preventing premature cascade deactivation when multiple condition branches point to same target
apps/sim/executor/handlers/condition/condition-handler.ts	Removed verbose logging statements and unnecessary parameters from condition evaluation logic

Sequence Diagram

sequenceDiagram
    participant Condition as Condition Block
    participant EM as EdgeManager
    participant DAG as DAG Nodes
    participant Target as Target Block

    Note over Condition,Target: Scenario: if→A, else→A (both branches to same target)
    
    Condition->>EM: processOutgoingEdges(output)
    Note over EM: Pass 1: Categorize edges
    EM->>EM: Check if edge (condition-if) should activate
    EM->>EM: selectedOption !== 'if', mark for deactivation
    EM->>EM: Check if edge (condition-else) should activate
    EM->>EM: selectedOption === 'else', add to activatedTargets
    
    Note over EM: Pass 2: Deactivate edges
    EM->>EM: deactivateEdgeAndDescendants(condition→A-condition-if)
    EM->>EM: hasActiveIncomingEdges(A, excludeEdgeKey)
    Note over EM: Key fix: Checks if OTHER edges to A are active
    EM->>EM: Found active edge (condition-else), skip cascade
    
    Note over EM: Pass 3: Update incoming edges
    EM->>DAG: targetNode.incomingEdges.delete(condition)
    
    Note over EM: Pass 4: Check readiness
    EM->>EM: isNodeReady(targetNode A)
    EM->>EM: incomingEdges.size === 0, ready!
    EM-->>Condition: return [A]
    
    Note over Target: Target A executes (correct!)
    Note over Condition,Target: Bug was: Both edges had same ID, else overwrote if<br/>Fix: Edge IDs now include sourceHandle suffix

Loading

[al7566]

@rodrick-mpofu