fix(helm): add custom egress rules to realtime network policy#2481
Merged
waleedlatif1 merged 1 commit intosimstudioai:mainfrom Dec 20, 2025
Merged
Conversation
|
@Lutherwaves is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThis PR fixes a missing configuration section in the realtime service network policy. The change adds the custom egress rules template block to the realtime network policy, bringing it into parity with the app network policy.
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User/DevOps
participant Values as values.yaml
participant Helm as Helm Template Engine
participant RT as Realtime Network Policy
participant Ext as External Database
User->>Values: Configure networkPolicy.egress<br/>with custom rules
User->>Helm: Deploy/upgrade chart
Helm->>RT: Render template with<br/>custom egress rules
Note over RT: Before fix: Custom rules ignored<br/>After fix: Custom rules included
RT->>Ext: Allow egress to external DB<br/>(e.g., PostgreSQL :5432)
Ext-->>RT: Connection successful
|
The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
4b1ab75 to
31147b6
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
majiayu000
pushed a commit
to majiayu000/sim
that referenced
this pull request
Dec 27, 2025
…dioai#2481) The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
majiayu000
pushed a commit
to majiayu000/sim
that referenced
this pull request
Dec 27, 2025
…dioai#2481) The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
Sg312
added a commit
that referenced
this pull request
Jan 10, 2026
* fix(helm): add custom egress rules to realtime network policy (#2481) The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml. * Add subagents * Edit, plan, debug subagents * Tweaks * Message queue * Many subagents * Fix bugs * Trigger request * Overlays * Diff in chat * Remove context usage code * Diff view in chat * Options * Lint * Fix rendering of edit subblocks * Add deploy mcp tools * Add evaluator subagent * Editor component * Options select * Fixes to options * Fix spacing between options * Subagent rendering * Fix previews * Plan * Streaming * Fix thinking scroll * Renaming * Fix thinking text * Persist and load chats properly * Diff view * Fix lint * Previous options should not be selectable * Enable images * improvement(copilot): ui/ux * improvement(copilot): diff controls * Fix ops bug * Fix ops * Stuff * Fix config --------- Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com> Co-authored-by: Waleed <walif6@gmail.com> Co-authored-by: Martin Yankov <23098926+Lutherwaves@users.noreply.github.com> Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com> Co-authored-by: waleedlatif1 <waleedlatif1@users.noreply.github.com> Co-authored-by: Adam Gough <77861281+aadamgough@users.noreply.github.com> Co-authored-by: aadamgough <adam@sim.ai> Co-authored-by: Emir Karabeg <emirkarabeg@berkeley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations.
The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values.
This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
Fixes https://discord.com/channels/1344142560293290024/1441430398155493396/1441430398155493396
Type of Change
Testing
could not receive data from client: Connection reset by peerwas thrown by PSQLChecklist