feat(kb): Adding support for more tags to the KB by Pbonmars-20031006 · Pull Request #2433 · simstudioai/sim

Pbonmars-20031006 · 2025-12-17T23:00:47Z

Summary

Adding more KB tag types + filters.

Type of Change

New feature

Testing

Tested Manually.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

- Update base-tags-modal with field type selector dropdown - Update document-tags-modal with different input types per fieldType - Update knowledge-tag-filters with operator dropdown and type-specific inputs - Update search routes to support all tag slot types - Update hook to use AllTagSlot type

- Add dropdown with all field types (Text, Number, Date, Boolean) - Render different value inputs based on field type - Update slot counting to include all field types (28 total)

- Replace MAX_TAG_SLOTS with totalSlots in document-tag-entry - Add z-index to SelectContent in base-tags-modal for proper layering

- Only apply empty string check for text columns (tag1-tag7) - Numeric/date/boolean columns only check IS NOT NULL - Cast values to text for consistent output

- Replace @/components/ui imports with @/components/emcn - Use Combobox instead of Select for dropdowns - Use EMCN Switch, Button, Input, Label components - Remove unsupported 'size' prop from EMCN Button

- Change delete button from absolute to inline positioning - Add proper column width (w-10) for delete button - Add empty header cell for delete column - Apply fix to both document-tag-entry and knowledge-tag-filters

- Reset value to empty when changing type (e.g., boolean to text) - Reset value when tag name changes and type differs - Prevents 'true'/'false' from sticking in text inputs

…arch - Copy all tag types (number, date, boolean) from document to embedding records - Update processDocumentTags to handle all field types with proper type conversion - Add number/date/boolean columns to document queries in checkDocumentWriteAccess - Update chunk creation to inherit all tag types from parent document - Add getSearchResultFields helper for consistent query result selection - Support structured filters with operators (eq, gt, lt, between, etc.) - Fix search queries to include all 28 tag fields in results

vercel · 2025-12-17T23:00:51Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Dec 20, 2025 4:57am

julius_caesar.txt

icecrasher321 · 2025-12-18T01:57:50Z

@Pbonmars-20031006 also don't forget to generate the migration using bunx drizzle-kit generate to the sql, snapshot, etc shows up [you can do that before me merge]

icecrasher321 · 2025-12-18T19:34:12Z

@Pbonmars-20031006 build failing here

Also, we realized that the write speed would become really slow if we have this many indices. Can we have 3 for number and 2 for date.

And for text have more filters like "contains" and "starts with" if they have equivalent sql ops -- e.g. https://stackoverflow.com/questions/1069302/using-the-star-sign-in-grep

greptile-apps · 2025-12-18T21:21:19Z

Greptile Summary

Extends knowledge base tagging system to support typed tags (number, date, boolean) beyond text tags with structured filtering capabilities including operators like equals, greater than, between, and contains
Adds comprehensive database schema changes with typed columns (number1-5, date1-2, boolean1-3) and corresponding indexes to both document and embedding tables
Implements new UI components including DatePicker, structured filter interfaces, and type-specific input controls for managing the enhanced tagging system

Important Files Changed

Filename	Overview
`packages/db/migrations/0126_dapper_midnight.sql`	Database migration adding typed tag columns (number, date, boolean) to document/embedding tables with indexes for filtering
`apps/sim/lib/knowledge/constants.ts`	Schema mismatch - hardcodes 5 number/2 date/3 boolean slots but database migration creates7 of each type
`apps/sim/lib/knowledge/filters/query-builder.ts`	Comprehensive query builder for typed tag filtering with SQL generation, but slot validation conflicts with database schema
`apps/sim/lib/knowledge/documents/service.ts`	Breaking changes to processDocumentTags function signature and return type, requires existing tag definitions

Confidence score: 2/5

This PR requires careful review due to critical schema inconsistencies that will cause runtime failures
Score lowered due to hardcoded slot count mismatches between constants (5,2,3) and database migration (7,7,7 for each type), breaking changes in service functions, and potential type safety issues where validation logic conflicts with database schema
Pay close attention to schema files, constants definitions, and query builder validation logic to resolve slot count inconsistencies

greptile-apps

_{24 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/lib/knowledge/constants.ts

apps/sim/lib/knowledge/tags/service.ts

apps/sim/lib/knowledge/filters/query-builder.ts

icecrasher321 · 2025-12-20T04:06:43Z

@greptile

greptile-apps

Additional Comments (3)

apps/sim/lib/knowledge/chunks/service.ts, line 181-187 (link)

logic: Return object missing typed tags - only includes text tags (tag1-tag7) but should also include number, date, and boolean tags that were assigned during creation.
apps/sim/app/api/knowledge/[id]/documents/route.test.ts, line 342-348 (link)

logic: Missing new typed tag fields (number1-5, date1-2, boolean1-3) that were added to the main mockDocument. This inconsistency could cause test failures if the actual service returns these fields.
apps/sim/tools/knowledge/search.ts, line 33-41 (link)

logic: Parameter schema doesn't reflect new structured format - missing fieldType, operator, tagSlot, valueTo fields that are used in the implementation

_{34 files reviewed, 12 comments}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/lib/knowledge/tags/utils.ts

apps/sim/tools/knowledge/search.ts

apps/sim/lib/knowledge/filters/query-builder.ts

apps/sim/lib/knowledge/documents/service.ts

icecrasher321 · 2025-12-20T04:33:56Z

@greptile

greptile-apps

_{34 files reviewed, 15 comments}

_{Edit Code Review Agent Settings | Greptile}

apps/sim/stores/knowledge/store.ts

apps/sim/app/api/knowledge/[id]/documents/route.test.ts

apps/sim/app/api/knowledge/[id]/documents/[documentId]/route.ts

packages/db/constants.ts

apps/sim/components/emcn/components/date-picker/date-picker.tsx

apps/sim/lib/knowledge/types.ts

.../components/editor/components/sub-block/components/document-tag-entry/document-tag-entry.tsx

...nents/editor/components/sub-block/components/knowledge-tag-filters/knowledge-tag-filters.tsx

apps/sim/app/api/knowledge/search/utils.ts

priyanshu.solanki added 9 commits December 17, 2025 12:33

creating boolean, number and date tags with different equality matchings

4f5f140

feat: add field type support to document-tag-entry component

3390f64

- Add dropdown with all field types (Text, Number, Date, Boolean) - Render different value inputs based on field type - Update slot counting to include all field types (28 total)

fix: resolve MAX_TAG_SLOTS error and z-index dropdown issue

511d891

- Replace MAX_TAG_SLOTS with totalSlots in document-tag-entry - Add z-index to SelectContent in base-tags-modal for proper layering

fix: handle non-text columns in getTagUsage query

030d8b6

- Only apply empty string check for text columns (tag1-tag7) - Numeric/date/boolean columns only check IS NOT NULL - Cast values to text for consistent output

refactor: use EMCN components for KB UI

38f46bd

- Replace @/components/ui imports with @/components/emcn - Use Combobox instead of Select for dropdowns - Use EMCN Switch, Button, Input, Label components - Remove unsupported 'size' prop from EMCN Button

fix: layout for delete button next to date picker

c23d6db

- Change delete button from absolute to inline positioning - Add proper column width (w-10) for delete button - Add empty header cell for delete column - Apply fix to both document-tag-entry and knowledge-tag-filters

fix: clear value when switching tag field type

21174d8

- Reset value to empty when changing type (e.g., boolean to text) - Reset value when tag name changes and type differs - Prevents 'true'/'false' from sticking in text inputs

Pbonmars-20031006 changed the base branch from main to staging December 17, 2025 23:01

fixing tags import issue

d44b1af

vercel bot deployed to Preview December 18, 2025 00:08 View deployment

icecrasher321 reviewed Dec 18, 2025

View reviewed changes

julius_caesar.txt Outdated Show resolved Hide resolved

fix rm file

c9c6ba9

vercel bot deployed to Preview December 18, 2025 01:58 View deployment

reduced number to 3 and date to 2

1612a8a

vercel bot temporarily deployed to Preview December 18, 2025 20:43 Inactive

fixing lint

1725ced

vercel bot temporarily deployed to Preview December 18, 2025 20:44 Inactive

fixed the prop size issue

78bbedd

vercel bot temporarily deployed to Preview December 18, 2025 21:01 Inactive

increased number from 3 to 5 and boolean from 7 to 2

523fc5e

vercel bot temporarily deployed to Preview December 18, 2025 21:17 Inactive

icecrasher321 marked this pull request as ready for review December 18, 2025 21:18

greptile-apps bot reviewed Dec 18, 2025

View reviewed changes

apps/sim/lib/knowledge/constants.ts Show resolved Hide resolved

apps/sim/lib/knowledge/tags/service.ts Show resolved Hide resolved

apps/sim/lib/knowledge/filters/query-builder.ts Show resolved Hide resolved

fixed number the sql stuff

4d83cb7

icecrasher321 added 4 commits December 18, 2025 17:06

progress

22745f7

fix document tag and kb tag modals

d5fd88d

update datepicker emcn component

3e49031

fix ui

44c513c

vercel bot temporarily deployed to Preview December 19, 2025 04:02 Inactive

icecrasher321 added 2 commits December 19, 2025 18:56

progress on KB block tags UI

bbc69a6

fix issues with date filters

869ad55

vercel bot temporarily deployed to Preview December 20, 2025 03:28 Inactive

fix execution parsing of types for KB tags

ca59aae

vercel bot temporarily deployed to Preview December 20, 2025 03:55 Inactive

icecrasher321 added 3 commits December 19, 2025 19:56

remove migration before merge

90e32df

Merge branch 'staging' into feat/filter-tags-update

8c6dd3a

regen migrations

dda74b9

vercel bot deployed to Preview December 20, 2025 04:00 View deployment

fix tests and types

51f1ce1

vercel bot temporarily deployed to Preview December 20, 2025 04:06 Inactive

greptile-apps bot reviewed Dec 20, 2025

View reviewed changes

icecrasher321 added 2 commits December 19, 2025 20:23

address greptile comments

eae7f7b

fix more greptile comments

1d10772

vercel bot temporarily deployed to Preview December 20, 2025 04:33 Inactive

greptile-apps bot reviewed Dec 20, 2025

View reviewed changes

fix filtering logic for multiple of same row

8a91eaf

vercel bot temporarily deployed to Preview December 20, 2025 04:54 Inactive

fix tests

998859d

vercel bot temporarily deployed to Preview December 20, 2025 04:57 Inactive

icecrasher321 merged commit 4f69b17 into staging Dec 20, 2025
10 checks passed

waleedlatif1 mentioned this pull request Dec 20, 2025

v0.5.37: redaction utils consolidation, logs updates, autoconnect improvements, additional kb tag types #2499

Merged

waleedlatif1 deleted the feat/filter-tags-update branch December 21, 2025 01:12

Conversation

Pbonmars-20031006 commented Dec 17, 2025 • edited by icecrasher321 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Dec 18, 2025

Uh oh!

icecrasher321 commented Dec 18, 2025

Uh oh!

greptile-apps bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Important Files Changed

Confidence score: 2/5

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Dec 20, 2025

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (3)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

icecrasher321 commented Dec 20, 2025

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pbonmars-20031006 commented Dec 17, 2025 •

edited by icecrasher321

Loading

vercel bot commented Dec 17, 2025 •

edited

Loading

greptile-apps bot commented Dec 18, 2025 •

edited

Loading

greptile-apps bot left a comment •

edited

Loading