fix(condition): used isolated vms for condition block RCE#2432
Merged
waleedlatif1 merged 5 commits intostagingfrom Dec 17, 2025
Merged
fix(condition): used isolated vms for condition block RCE#2432waleedlatif1 merged 5 commits intostagingfrom
waleedlatif1 merged 5 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
9c3feb9 to
2e98a3f
Compare
Contributor
Greptile SummaryThis PR addresses a critical Remote Code Execution (RCE) vulnerability by replacing unsafe Key Security Improvements:
Additional Changes:
The changes systematically eliminate all RCE vectors from condition and loop evaluation paths by ensuring untrusted code cannot access the parent process context. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ConditionHandler
participant LoopOrchestrator
participant IsolatedVM
participant Worker
User->>ConditionHandler: Execute condition block
ConditionHandler->>ConditionHandler: Resolve variable references
ConditionHandler->>IsolatedVM: executeInIsolatedVM(code, context)
IsolatedVM->>Worker: Send execute message (IPC)
Worker->>Worker: Run code in isolated V8 context
Worker-->>IsolatedVM: Return result (IPC)
IsolatedVM-->>ConditionHandler: Return { result, error? }
ConditionHandler-->>User: Return condition evaluation result
User->>LoopOrchestrator: Evaluate loop continuation
LoopOrchestrator->>LoopOrchestrator: Resolve references in condition
LoopOrchestrator->>IsolatedVM: executeInIsolatedVM(code, context)
IsolatedVM->>Worker: Send execute message (IPC)
Worker->>Worker: Run code in isolated V8 context
Worker-->>IsolatedVM: Return result (IPC)
IsolatedVM-->>LoopOrchestrator: Return { result, error? }
LoopOrchestrator-->>User: Return loop decision
|
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@greptile |
Collaborator
Author
|
@greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist