fix(firecrawl): updated output for firecrawl extract#2333
Merged
waleedlatif1 merged 3 commits intostagingfrom Dec 12, 2025
Merged
fix(firecrawl): updated output for firecrawl extract#2333waleedlatif1 merged 3 commits intostagingfrom
waleedlatif1 merged 3 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryUpdated Firecrawl extract and search tool outputs to remove unused fields (
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Client
participant Tool as Firecrawl Tools
participant API as Firecrawl API
Note over Client,API: Extract Tool Flow
Client->>Tool: Call extract with URLs, prompt/schema
Tool->>API: POST /v2/extract
API-->>Tool: Returns jobId
Tool->>Tool: Start polling (5s intervals, 5min max)
loop Poll until complete/failed
Tool->>API: GET /v2/extract/{jobId}
API-->>Tool: Returns status & data
alt Status: completed
Tool-->>Client: Returns {success, jobId, data}
else Status: failed
Tool-->>Client: Returns error
end
end
Note over Client,API: Search Tool Flow
Client->>Tool: Call search with query
Tool->>API: POST /v2/search
API-->>Tool: Returns search results
Tool-->>Client: Returns {data}
Note over Client,API: Crawl Tool Flow
Client->>Tool: Call crawl with URL
Tool->>API: POST /v2/crawl
API-->>Tool: Returns jobId
Tool->>Tool: Start polling (5s intervals, 5min max)
loop Poll until complete/failed
Tool->>API: GET /v2/crawl/{jobId}
API-->>Tool: Returns status & pages
alt Status: completed
Tool-->>Client: Returns {pages, total, creditsUsed}
else Status: failed
Tool-->>Client: Returns error
end
end
|
Contributor
There was a problem hiding this comment.
Additional Comments (2)
-
apps/sim/tools/firecrawl/types.ts, line 196-207 (link)logic:
ExtractResponsetype includessourcesandwarningfields but they're removed from extract.ts outputs -
apps/sim/tools/firecrawl/types.ts, line 147-168 (link)logic:
SearchResponsetype includeswarningfield but it's removed from search.ts transformResponse
6 files reviewed, 2 comments
Collaborator
Author
|
@greptile |
This was referenced Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist