fix(settings): fixed sso form validation#2189
Merged
waleedlatif1 merged 1 commit intostagingfrom Dec 4, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile OverviewGreptile SummaryThis PR fixes SSO form validation in the settings modal with three key improvements:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SSO Form
participant validateAll()
participant handleSubmit()
participant API
User->>SSO Form: Changes provider type (OIDC→SAML)
SSO Form->>SSO Form: setShowErrors(false)
SSO Form->>validateAll(): Validate with new provider type
validateAll()->>SSO Form: Update error state for SAML fields
User->>SSO Form: Fills SAML fields
SSO Form->>validateAll(): Validate on each input
User->>SSO Form: Click Save
SSO Form->>handleSubmit(): Submit form
handleSubmit()->>validateAll(): Final validation
alt Has Errors
validateAll()->>SSO Form: Show errors
else No Errors
handleSubmit()->>API: POST SSO config
API-->>SSO Form: Success response
end
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist