fix(variables, webhook): fix variable tag dropdown for escaped < and allow empty webhook payload

[Sg312]

Summary

Fix variable tag dropdown for escaped < and allow empty webhook payload

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 8, 2025 1:58am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR fixes two distinct bugs: variable tag dropdown incorrectly handling escaped < characters (like in comparisons < <block.output>), and webhook processor rejecting valid empty payloads.

Key Changes:

• Introduced splitReferenceSegment() function to properly parse variable references when preceded by comparator operators (<, <=, etc.)
• Updated getTagSearchTerm() to use lastIndexOf() to find the most recent unclosed < bracket
• Modified webhook processor to accept empty request bodies and empty JSON objects, returning {body: {}, rawBody: ''} instead of 400 errors
• Applied the new reference parsing logic consistently across tag dropdown, formatted text display, and code/condition input components
• Added comprehensive test coverage for the new parsing logic
• Removed unused OAuthService import

The changes are well-structured with proper separation of concerns. The new splitReferenceSegment utility is reusable and tested. The webhook change aligns with common webhook patterns where empty payloads are valid.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-tested, focused, and address specific bugs without introducing complexity. The new splitReferenceSegment function has proper test coverage and is applied consistently. The webhook change is a simple, logical fix that improves compatibility. No breaking changes or security concerns identified.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/workflows/references.ts	5/5	Added splitReferenceSegment function to properly handle escaped < characters in variable references and updated isLikelyReferenceSegment to use it
apps/sim/lib/webhooks/processor.ts	5/5	Changed to allow empty webhook payloads by returning empty objects instead of 400 errors
apps/sim/components/ui/tag-dropdown.tsx	5/5	Extracted getTagSearchTerm and updated search logic to use lastIndexOf for proper handling of escaped < characters
apps/sim/components/ui/formatted-text.tsx	5/5	Updated to use splitReferenceSegment for proper handling of escaped < in display text highlighting

Sequence Diagram

sequenceDiagram
    participant User
    participant UI as Tag Dropdown/Input
    participant Split as splitReferenceSegment
    participant Filter as Tag Filter Logic
    participant Display as Formatted Text

    Note over User,Display: Scenario 1: Variable Tag Dropdown
    User->>UI: Types "< <block.output>"
    UI->>Split: getTagSearchTerm("< <block.output>", 18)
    Split->>Split: lastIndexOf('<') finds last <
    Split->>Split: Check if > after last <
    Split-->>UI: Returns "" (empty search)
    UI->>UI: Shows all tags

    Note over User,Display: Scenario 2: Reference Highlighting
    User->>Display: Displays text with "< <block.output>"
    Display->>Split: splitReferenceSegment("< <block.output>")
    Split->>Split: Finds last < at position 2
    Split->>Split: Extracts leading="< ", reference="<block.output>"
    Split-->>Display: {leading: "< ", reference: "<block.output>"}
    Display->>Display: Render "< " as plain, "<block.output>" as blue

    Note over User,Display: Scenario 3: Webhook Empty Payload
    participant Webhook as Webhook Processor
    participant Parser as parseWebhookBody
    User->>Webhook: POST /webhook (empty body)
    Webhook->>Parser: parseWebhookBody(request)
    Parser->>Parser: Read body text
    Parser->>Parser: Check if empty
    Parser-->>Webhook: {body: {}, rawBody: ''}
    Webhook->>Webhook: Continue processing with empty object

Loading

_{9 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}