feat(permissions): allow users to deploy workflows in all workspaces they are an admin in#1463
Merged
waleedlatif1 merged 5 commits intostagingfrom Sep 27, 2025
Merged
feat(permissions): allow users to deploy workflows in all workspaces they are an admin in#1463waleedlatif1 merged 5 commits intostagingfrom
waleedlatif1 merged 5 commits intostagingfrom
Conversation
waleedlatif1
force-pushed
the
fix/deploy
branch
from
72d9126 to
4a943cd
Compare
waleedlatif1
force-pushed
the
fix/deploy
branch
from
4a943cd to
1029770
Compare
waleedlatif1
force-pushed
the
fix/deploy
branch
from
f12f95e to
dbdc3c5
Compare
waleedlatif1
force-pushed
the
fix/deploy
branch
from
dbdc3c5 to
c45fa2f
Compare
waleedlatif1
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow admin workspace users to deploy workflows in workspaces they don't own. previously, when deploying, we only checked 1) if its a workspace key then its good or 2) if its a personal key, then only the owner can deploy.
since we have phased out
ownerand have workspace-level permissions, we should rely on those for everything and not the workspace owner since that's not relevant.Type of Change
Testing
Manually. Also ensured that the pinnedApiKey displays even if I (User A) own the workspace, and User B (admin) deploys with a personal key, I can still see the preview of what key the workflow is deployed with. Basically, if I can see the modal I can see the preview of the key it was deployed with.
Checklist
Screenshots/Videos