Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Greptile Overview
Summary
This PR partially removes turbopack by removing the --turbopack flag from the build script, reverting to webpack for production builds. However, the removal is incomplete as the dev script still uses the --turbo flag.
- Removes
--turbopackfrom build script, switching production builds back to webpack - Creates inconsistency: development still uses turbopack while production uses webpack
- May impact build performance and behavior differences between environments
Confidence Score: 2/5
- This PR has inconsistent turbopack removal that could cause dev/prod environment differences
- Score reflects incomplete implementation with potential environment inconsistencies between development and production builds
- apps/sim/package.json requires attention to complete turbopack removal consistently
Important Files Changed
File Analysis
| Filename | Score | Overview |
|---|---|---|
| apps/sim/package.json | 2/5 | Inconsistent turbopack removal - build script updated but dev script still has --turbo flag |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant CI as CI/CD Pipeline
participant Next as Next.js
participant Turbo as Turbopack
Note over Dev, Turbo: Before: Build Process with Turbopack
Dev->>CI: Triggers build process
CI->>Next: Runs "next build --turbopack"
Next->>Turbo: Uses turbopack bundler
Turbo->>Next: Returns optimized build
Next->>CI: Build complete with turbopack
Note over Dev, Turbo: After: Build Process without Turbopack
Dev->>CI: Triggers build process
CI->>Next: Runs "next build" (default webpack)
Next->>Next: Uses default webpack bundler
Next->>CI: Build complete with webpack
Note over Dev: Issue: Dev script still uses --turbo flag
Dev->>Next: Runs "next dev --turbo --port 3000"
Next->>Turbo: Still uses turbopack in development
1 file reviewed, 1 comment
Sg312
changed the title
Sg312
changed the title
| on: | ||
| push: | ||
| branches: [main, staging] | ||
| workflow_call: |
Contributor
Author
There was a problem hiding this comment.
makes it reusable (can be called from ci)
| resolveExtensions: ['.tsx', '.ts', '.jsx', '.js', '.mjs', '.json'], | ||
| }, | ||
| serverExternalPackages: ['pdf-parse'], | ||
| serverExternalPackages: ['pdf-parse', '@azure/storage-blob'], |
Collaborator
There was a problem hiding this comment.
was this actually needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes turbopack for dh builds
Fixes #(issue)
Type of Change
Testing
Local
Checklist