fix(subflow-validation): validate subflow fields correctly + surface serialization errors in the logs correctly #1299
Conversation
…serialiazation errors in the logs correctly
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR fixes critical workflow validation issues affecting For Each loops and Parallel Each blocks that were causing workflow execution failures. The changes implement comprehensive pre-execution validation and improve error handling across three key areas:
Serializer Validation Enhancement: The Serializer class now includes a WorkflowValidationError class and validateSubflowsBeforeExecution method that validates subflow configurations before execution. This validation checks that forEach loops have valid collections and collection-based parallels have valid distributions, supporting multiple data formats (arrays, objects, strings, JSON) and variable references like <start.items>. The validation is triggered when validateRequired=true during serialization.
Dynamic Subflow Generation: The workflow execution hook now generates loop and parallel configurations dynamically from the current workflow state instead of using potentially stale stored configurations. This prevents validation failures when users modify blocks by calling generateLoopBlocks(filteredStates) and generateParallelBlocks(filteredStates) to create fresh runtime configurations, then enabling validation during serialization.
Enhanced Error Logging: The workflow log API now properly handles failed executions by checking result.success === false and calling safeCompleteWithError instead of treating all executions as successful. It also extracts actual user and workspace IDs from the validated workflow instead of using empty strings. Additionally, serialization errors are now surfaced to the console with structured error information including block context for better debugging.
These changes work together to catch validation errors early in the workflow lifecycle, provide better error reporting to users, and ensure that subflow blocks have valid configurations before execution begins.
Confidence score: 4/5
- This PR addresses critical workflow execution failures with well-structured validation logic and error handling
- Score reflects solid implementation of validation patterns and proper error propagation throughout the system
- Pay close attention to the complex validation logic in
validateSubflowsBeforeExecutionmethod for edge cases
3 files reviewed, no comments
…serialization errors in the logs correctly (#1299) * fix(subflow-validation): validate subflow fields correctly + surface serialiazation errors in the logs correctly * remove comments
…serialization errors in the logs correctly (simstudioai#1299) * fix(subflow-validation): validate subflow fields correctly + surface serialiazation errors in the logs correctly * remove comments
1 participant
Summary
For Each / Parallel Each were not being validated correctly -- breaking workflow executions.
Also surface serialization errors to the logs correctly.
Type of Change
Testing
Manually Tested.
Screen.Recording.2025-09-09.at.5.52.34.PM.mov
Checklist