v0.3.46: fix copilot stats updates #1238
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR implements a comprehensive fix for copilot statistics tracking by simplifying and centralizing the stats collection mechanism. The changes remove problematic early stats updates that were occurring at multiple points during workflow processing and consolidate stats tracking to only essential diff-related metrics.
The key changes include:
-
Simplified API Schema: The
/api/copilot/statsendpoint now only accepts three required fields (messageId,diffCreated,diffAccepted) instead of the previous complex schema with 11 optional fields including userId, chatId, duration, and token counts. -
Removed Premature Stats Updates: Early stats tracking has been eliminated from workflow building and editing tools that were sending stats immediately when diffs were created, before users had a chance to review changes.
-
Centralized Stats Collection: Stats are now only sent when users explicitly accept or reject copilot suggestions in the workflow diff store, providing a cleaner user-action-driven analytics approach.
-
Eliminated Redundant Parameters: The
chatIdparameter has been removed from client-side stats calls to align with the updated API contract.
These changes fit into the codebase's broader copilot system, which manages AI-generated workflow suggestions through a multi-store architecture. The copilot store handles message processing and API communication, while the workflow diff store manages the review and acceptance/rejection of proposed changes. By streamlining stats collection to focus only on the essential diff lifecycle events, this fix addresses reliability issues that were likely causing inconsistent or failed stats updates.
Confidence score: 4/5
- This PR appears safe to merge with good confidence as it simplifies existing functionality rather than adding complex new features
- Score reflects that this is primarily a bug fix that removes problematic code paths and consolidates stats tracking to a cleaner approach
- Pay close attention to the API route changes and ensure upstream SIM agent API compatibility with the new simplified payload structure
5 files reviewed, 1 comment
| const body = parsed.data as any | ||
|
|
||
| // Build outgoing payload for Sim Agent; do not include id | ||
| const { messageId, diffCreated, diffAccepted } = parsed.data as any |
There was a problem hiding this comment.
style: unnecessary type assertion since parsed.data is already typed from the Zod schema validation
| const { messageId, diffCreated, diffAccepted } = parsed.data as any | |
| const { messageId, diffCreated, diffAccepted } = parsed.data |
1 participant
Updates (#1237)