fix(build): add missing pdf-parse dep, add docker build in staging#1213
fix(build): add missing pdf-parse dep, add docker build in staging#1213waleedlatif1 merged 2 commits intostagingfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR addresses a build failure by adding the missing pdf-parse dependency and implements Docker build testing for the staging branch. The changes span two files:
Package Dependency Fix: The PR adds the missing pdf-parse version 1.1.1 runtime dependency to apps/sim/package.json. This was causing build failures because the code was attempting to use PDF parsing functionality, but only the TypeScript type definitions (@types/pdf-parse) were present without the actual runtime package. This is a common oversight when adding new functionality where developers include type support but forget the corresponding runtime dependency.
Docker Build Workflow Enhancement: The PR modifies .github/workflows/build.yml to support building Docker images on the staging branch in addition to main. The workflow now triggers on both branches but implements conditional logic to ensure Docker registry operations (login, push, manifest creation) only occur for the main branch. For staging builds, it creates architecture-specific tags using the commit SHA (staging-${{ github.sha }}-${{ matrix.arch }}) but doesn't push them to the registry. The PR also removes all tag-based triggers and semantic versioning logic, simplifying the build process to focus on branch-specific builds.
These changes integrate with the existing CI/CD pipeline by allowing earlier detection of Docker build issues in the staging environment before code reaches the main branch, while maintaining the existing production deployment process unchanged.
Confidence score: 2/5
- This PR has a critical flaw in the Docker workflow implementation that undermines its stated purpose
- Score lowered because staging Docker builds are configured but never pushed to registry, making build failure detection ineffective
- Pay close attention to
.github/workflows/build.ymlconditional logic and consider whether staging builds should actually be pushed
2 files reviewed, 1 comment
…1213) * fix(build): add missing pdf-parse dep * add docker build (no push) in staging
…1213) * fix(build): add missing pdf-parse dep * add docker build (no push) in staging
…imstudioai#1213) * fix(build): add missing pdf-parse dep * add docker build (no push) in staging
1 participant
Summary
add missing pdf-parse dep that caused a build failure, also added docker build in staging so we can detect failures to the docker build in staging, removed tag-related logic.
Type of Change
Testing
Tested build manually.
Checklist