Revert "fix(cursor-and-input): fixes cursor and input canvas error" #1178
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Greptile Summary
This PR reverts the complex cursor alignment and canvas error fixes that were implemented in PR #1168. The revert removes three interconnected components of a sophisticated viewport management system:
-
Workflow-level viewport management - Removes auto-panning logic in
workflow.tsxthat tracked content height and automatically adjusted the viewport when content overflowed. This included event listeners for layout changes, cursor position tracking, and anonMoveEndhandler for viewport epsilon adjustments. -
Input component scroll synchronization - Reverts the
long-input.tsxcomponent back to basic scroll handling, removing the sophisticated transform-based scroll synchronization between textarea and overlay elements, ResizeObserver for width matching, and explicit font styling that ensured perfect alignment. -
Block-level event coordination - Removes custom event dispatchers (
workflow-node-resizedandworkflow-layout-change) fromworkflow-block.tsxthat were used to coordinate between workflow blocks and input components during resize and layout changes.
The original fix was designed to address cursor misalignment issues and gray canvas errors when pasting long text into workflow input fields. The system worked by maintaining perfect synchronization between a textarea input and its visual overlay, while automatically managing viewport positioning to keep content visible. However, this complex solution likely introduced side effects such as unwanted viewport movements, interference with user interactions, or performance issues, prompting this revert to simpler, more predictable behavior.
The revert also includes some code duplication (a useEffect hook appears twice now) and simplifies several type annotations, indicating the complexity of the interdependencies that were removed.
Confidence score: 2/5
- This revert carries significant risk as it likely reintroduces the original cursor alignment and canvas error issues that users were experiencing
- Score reflects high probability that the original problems will resurface, potentially affecting user experience in workflow text inputs
- Pay close attention to the
long-input.tsxcomponent as it's the most likely to exhibit the reverted cursor alignment issues
3 files reviewed, 1 comment
| // Validate nested subflows whenever blocks change | ||
| useEffect(() => { | ||
| validateNestedSubflows() | ||
| }, [blocks, validateNestedSubflows]) |
There was a problem hiding this comment.
logic: Duplicate useEffect hook for nested subflow validation. This exact same effect is already defined at lines 1097-1099.
…imstudioai#1168)" (simstudioai#1178) This reverts commit aa84c75.
1 participant
Reverts #1168