Skip to content

fix(slack): set depends on for slack channel channel subblock#1177

Merged
icecrasher321 merged 4 commits intostagingfrom
fix/slack-channel-depends-on
Aug 29, 2025
Merged

fix(slack): set depends on for slack channel channel subblock#1177
icecrasher321 merged 4 commits intostagingfrom
fix/slack-channel-depends-on

Conversation

@icecrasher321
Copy link
Collaborator

Summary

Add dependsOn for Slack channel selector.

Type of Change

  • Bug fix

Testing

Manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Aug 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sim Ready Ready Preview Comment Aug 29, 2025 3:13am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Aug 29, 2025 3:13am

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds a dependsOn property to the Slack channel selector configuration in the Slack block. The change establishes a dependency relationship between the channel selector and two other form fields: 'credential' (OAuth token) and 'authMethod' (authentication method selection).

The Slack block supports multiple authentication methods - OAuth integration and custom bot tokens - and includes a channel selector that dynamically fetches available channels based on the current authentication context. When users switch between authentication methods or update their credentials, the channel selector needs to refresh its data to show channels accessible with the new authentication context.

This change integrates with the broader block configuration system that manages form field dependencies and UI state. The dependsOn property is a standard pattern used throughout the codebase to ensure form fields are properly invalidated and refreshed when their dependent fields change, maintaining data consistency in dynamic form interfaces.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects a simple, well-understood UI dependency fix with clear purpose and minimal scope
  • No files require special attention

1 file reviewed, no comments

Edit Code Review Bot Settings | Greptile

@vercel vercel bot temporarily deployed to Preview – docs August 29, 2025 03:03 Inactive
@vercel vercel bot temporarily deployed to Preview – docs August 29, 2025 03:06 Inactive
@icecrasher321 icecrasher321 changed the title fix(slack): set depends on for slack channel fix(slack): set depends on for slack channel channel subblock Aug 29, 2025
@icecrasher321 icecrasher321 merged commit ebb8cf8 into staging Aug 29, 2025
4 of 5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/slack-channel-depends-on branch August 29, 2025 05:01
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
…dioai#1177)

* fix(slack): set depends on for slack channel

* use foreign credential check

* fix

* fix clearing of block
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant