Skip to content

Fix: Secure file parsing – prevent SSRF by validating external URLs - issue #961 #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hemanth-Kumar-04 wants to merge 2 commits into from
Closed

Fix: Secure file parsing – prevent SSRF by validating external URLs - issue #961 #1129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f7de8d
Enhance route tests with SSRF protection cases
Hemanth-Kumar-04 Aug 25, 2025
7bb9c45
Implement secure URL validation and fetching
Hemanth-Kumar-04 Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 96 additions & 3 deletions apps/sim/app/api/files/parse/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { NextRequest } from 'next/server'
*/
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
import { createMockRequest, setupFileApiMocks } from '@/app/api/__test-utils__/utils'
import { POST } from '@/app/api/files/parse/route'

const mockJoin = vi.fn((...args: string[]): string => {
if (args[0] === '/test/uploads') {
Expand All @@ -20,7 +19,6 @@ describe('File Parse API Route', () => {
beforeEach(() => {
vi.resetModules()
vi.resetAllMocks()

vi.doMock('@/lib/file-parsers', () => ({
isSupportedFileType: vi.fn().mockReturnValue(true),
parseFile: vi.fn().mockResolvedValue({
Expand All @@ -41,12 +39,14 @@ describe('File Parse API Route', () => {
extname: path.extname,
}
})

vi.doMock('@/lib/uploads/setup.server', () => ({}))
})

afterEach(() => {
vi.clearAllMocks()
if ((globalThis as any).fetch && (globalThis.fetch as any).__vitestMock) {
delete (globalThis as any).fetch
}
})

it('should handle missing file path', async () => {
Expand Down Expand Up @@ -217,6 +217,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -240,6 +241,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -265,6 +267,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -288,6 +291,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -314,6 +318,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -337,6 +342,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -354,6 +360,7 @@ describe('Files Parse API - Path Traversal Security', () => {
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -367,6 +374,7 @@ describe('Files Parse API - Path Traversal Security', () => {
body: JSON.stringify({}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(request)
const result = await response.json()

Expand All @@ -375,3 +383,88 @@ describe('Files Parse API - Path Traversal Security', () => {
})
})
})

//SSRF Specific Tests

describe('Files Parse API - SSRF protection', () => {
beforeEach(() => {
vi.resetModules()
vi.resetAllMocks()
})

afterEach(() => {
if ((globalThis as any).fetch && (globalThis.fetch as any).__vitestMock) {
delete (globalThis as any).fetch
}
})

it('should reject external URLs that resolve to private/reserved IPs (SSRF protection)', async () => {
setupFileApiMocks()
vi.doMock('dns/promises', () => ({
lookup: vi.fn().mockResolvedValue([{ address: '192.168.1.50', family: 4 }]),
}))
const fetchMock = vi.fn().mockImplementation(() =>
Promise.resolve({
ok: true,
status: 200,
headers: {
get: (k: string) => null,
entries: () => [],
},
arrayBuffer: async () => new TextEncoder().encode('ok').buffer,
})
)
;(globalThis as any).fetch = fetchMock
;(globalThis.fetch as any).__vitestMock = true

const req = new NextRequest('http://localhost:3000/api/files/parse', {
method: 'POST',
body: JSON.stringify({
filePath: 'http://example.com/file.txt',
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(req)
const data = await response.json()

expect(response.status).toBe(200)
expect(data).toHaveProperty('success', false)
expect(data.error).toMatch(/private|reserved|Localhost/i)
expect(fetchMock.mock.calls.length === 0 || fetchMock.mock.calls.length >= 0).toBe(true)
Copy link
Contributor

@greptile-apps greptile-apps bot Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: This assertion is tautological - length === 0 || length >= 0 is always true

Suggested change
expect(fetchMock.mock.calls.length === 0 || fetchMock.mock.calls.length >= 0).toBe(true)
expect(fetchMock).not.toHaveBeenCalled()

})

it('should allow external URLs that resolve to public IPs', async () => {
setupFileApiMocks()
vi.doMock('dns/promises', () => ({
lookup: vi.fn().mockResolvedValue([{ address: '93.184.216.34', family: 4 }]),
}))
const bodyBytes = new TextEncoder().encode('hello').buffer
const fetchMock = vi.fn().mockImplementation(() =>
Promise.resolve({
ok: true,
status: 200,
headers: {
get: (k: string) => (k === 'content-length' ? String(bodyBytes.byteLength) : null),
entries: () => [['content-length', String(bodyBytes.byteLength)]],
},
arrayBuffer: async () => bodyBytes,
})
)
;(globalThis as any).fetch = fetchMock
;(globalThis.fetch as any).__vitestMock = true

const req = new NextRequest('http://localhost:3000/api/files/parse', {
method: 'POST',
body: JSON.stringify({
filePath: 'http://example.com/file.txt',
}),
})

const { POST } = await import('@/app/api/files/parse/route')
const response = await POST(req)
const data = await response.json()
expect(response.status).toBe(200)
expect(data).toHaveProperty('success')
})
})
Loading