Skip to content

fix(ux): minor ux changes#1109

Merged
icecrasher321 merged 3 commits intostagingfrom
fix/ux
Aug 23, 2025
Merged

fix(ux): minor ux changes#1109
icecrasher321 merged 3 commits intostagingfrom
fix/ux

Conversation

@aadamgough
Copy link
Contributor

Summary

Fixed auto connect inside sub flows, added scrollbar on side bar for console and variable, allowed for users to click out of variable tag dropdown, and allowed for variable collapse.

Type of Change

  • Other

Testing

See video

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Screenshots/Videos

Screen.Recording.2025-08-22.at.2.53.52.PM.mov

@vercel
Copy link

vercel bot commented Aug 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
sim Ready Ready Preview Comment Aug 22, 2025 10:22pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Aug 22, 2025 10:22pm

@aadamgough aadamgough marked this pull request as ready for review August 22, 2025 21:56
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR implements several minor UX improvements across the workflow editor interface. The changes focus on enhancing user interaction patterns and visual feedback:

Console and Variables Panel Enhancements: The console and variables components now show scrollbars by changing the hideScrollbar prop from true to false in their ScrollArea components. This provides better visual indication when content overflows and improves navigation through long lists of console entries or variables.

Variable Collapse Functionality: A new collapsible feature has been added to the variables panel, allowing users to minimize individual variables to reduce visual clutter. The implementation uses React state management with collapsedById state to track which variables are collapsed, and adds a toggle button in the options dropdown with conditional Maximize2/Minimize2 icons. The value editor is conditionally rendered based on the collapsed state.

Tag Dropdown Click-Outside Behavior: The TagDropdown component now supports dismissing the dropdown by clicking outside of it. This is implemented using a useRef hook to reference the dropdown container and a useEffect that listens for mousedown and touchstart events outside the dropdown, following standard UX patterns for overlay dismissal.

Auto-Connect Logic Improvement: The workflow auto-connect behavior for blocks dropped inside sub-flows (loop/parallel containers) has been enhanced. Previously, new blocks would always connect to the container's start handle. Now, when existing child blocks are present, new blocks connect to the nearest existing child block instead, creating more intuitive sequential flows within containers while maintaining backward compatibility.

These changes integrate well with the existing codebase architecture, using established patterns like React hooks, conditional rendering, and the existing ScrollArea component from the UI library. The improvements enhance the overall user experience without introducing breaking changes to the workflow editor functionality.

Confidence score: 5/5

  • This PR is safe to merge with minimal risk
  • Score reflects simple, well-isolated UX improvements with proper React patterns and no breaking changes
  • No files require special attention

4 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

@icecrasher321 icecrasher321 merged commit 79dd1cc into staging Aug 23, 2025
5 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/ux branch August 24, 2025 08:03
arenadeveloper02 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Sep 19, 2025
* minor UX fixes

* changed variable collapse

* lint

---------

Co-authored-by: Adam Gough <adamgough@Mac.attlocal.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants