integrate ruff linter #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
As a generated file cli.py needs to be excluded, otherwise the build check for the generator will fail |
Contributor
|
I like this! The PR currently still includes changes to |
Member
Author
|
Thanks for the feedback guys. Will address them. Since we are nearing release, I don't want to push the changes as a part of the current release. |
Contributor
|
The added tox configuration refers to environments that are not present in the configuration. I'd suggest removing the |
Member
Author
|
currently with the changes in this PR, integration tests are failing. So will create PRs in parts so that it's easier to debug issues and review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes