-
Notifications
You must be signed in to change notification settings - Fork 0
PrivMX Endpoint Swift 2.3.0 #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Drejzer
wants to merge
41
commits into
main
Choose a base branch
from
2.3.0-staging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging patch 2.2.1 and syncing dev with main
Feat!: New Handle Aliases
Switched to PrivMX Endpoint v2.3.1-rc1
Feat: getContextUsers
Refactor: filevector comparison
Feat: Implemented EventApi
Feat: getChannel method
* Included new public headers * Cxx part of implementing setUserVerifier * Swift part of implementing setUserVerifier
* Cxx wrapper * New error cases for cryptoApi methods * missing error case * Added Swift part of the wrapper for the new methods. * Added docs for the new methods (copied from cpp) + code fix * corrected throw error case in conversin method
* leverage Buffer == operator in FileVector comparison * Added ExtKey wrapper * Added BIP39 wrapper * Workaround for swiftlang/swift#81327 * ExtKey docs * BIP39 docs
* Added nonthrowing wrapper for Utils * added new error cases * Added swift enums with static methods for utils methods
* Refactor: changed the verifier implementation (now uses wrapper structs for input and oputput) * Updated struct names and added doc comments
filipg43
reviewed
May 19, 2025
/// | ||
/// - Parameter data: string to split | ||
/// - Parameter delimiter: string which will be split | ||
/// - Returns: vector containing all split parts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update did not make it to 2.3.0 release of the C++ library
@zurekz
zurekz
approved these changes
May 20, 2025
djenczewski
approved these changes
May 20, 2025
…st` to `resultVector` and `requestVector` fields respectively
filipg43
approved these changes
May 20, 2025
djenczewski
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.