Valentin dissais #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it-testing, and this particular Angular-seed
… a component to the HomeModule, this is probably why I am unable to make template files
Collaborator
|
Bonjour Valentin, J'ai bien accès à une partie des modifications de la PR, mais tant via l'interface qu'en pullant votre PR, je ne vois pas les dossiers et fichiers que vous avez ajouté (exemple /store/pokemon-list.reducers). En revanche je vois bien les modification sur les fichiers existants, ce qui me pousse à penser que vous avez oublié de "git add ." avant de commit/push vos changements. Pouvez vous les rajouter de manière à ce que je puisse faire la revue ? Merci ! |
Author
|
Oui pardon! Je fais ca au plus vite!
Le 14 sept. 2017 15:47, "Shireilia" <notifications@github.com> a écrit :
… Bonjour Valentin,
J'ai bien accès à une partie des modifications de la PR, mais tant via
l'interface qu'en pullant votre PR, je ne vois pas les dossiers et fichiers
que vous avez ajouté (exemple /store/pokemon-list.reducers). En revanche je
vois bien les modification sur les fichiers existants, ce qui me pousse à
penser que vous avez oublié de "git add ." avant de commit/push vos
changements. Pouvez vous les rajouter de manière à ce que je puisse faire
la revue ? Merci !
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVsJjjUrqcvXHy3E5RwwfKPZD_CrU3AIks5siS5_gaJpZM4PXkPy>
.
|
Collaborator
|
C'est tout bon, je peux review, merci :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know I'm not the best at unit-testing and NgRx, these are the two main things I will work on!
Also, I'm used to work with the Angular-cli, this seed-project is a bit confusing! (never managed to correctly declare my first component)