Merged
Conversation
This reverts commit 32a1f7f.
spaced4ndy
reviewed
Oct 9, 2025
spaced4ndy
reviewed
Oct 9, 2025
spaced4ndy
reviewed
Oct 9, 2025
| getAllSndQueuesForDelivery db = map toSndQueue <$> DB.query_ db (sndQueueQuery <> " " <> delivery) | ||
| where | ||
| delivery = [sql| | ||
| JOIN (SELECT DISTINCT conn_id, snd_queue_id FROM snd_message_deliveries WHERE failed = 0) d |
Collaborator
There was a problem hiding this comment.
wouldn't this skip queue altogether for delivery, even if it has some failed delivery? delivery is work item, I'm not sure it's correct to exclude queue here - though maybe it's fine for the context it's used in - highlighting to double check
Member
Author
There was a problem hiding this comment.
why would it be excluded? it picks distinct conn_id, snd_queue_id fields for rows where failed = 0.
spaced4ndy
reviewed
Oct 9, 2025
spaced4ndy
reviewed
Oct 9, 2025
| <$> DB.query_ | ||
| db | ||
| [sql| | ||
| SELECT DISTINCT c.user_id, q.host, q.port, COALESCE(q.server_key_hash, s.key_hash) |
Collaborator
There was a problem hiding this comment.
check SELECT DISTINCT in postgres
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.