Small tweaks #57
Merged
Small tweaks #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
benjaminreid
commented
Aug 17, 2018
•
benjaminreid
commented
- Makes the scenes code consistent with the generated ones
- Small bits of tidy up
- Make components consistent with generated ones
- Fix type imports
- Fix version bump command
craigcoles
approved these changes
Aug 17, 2018
| const Styleguide = ({ installed, requestExample }: Props): React.Node => ( | ||
| <Layout.Scroll header> | ||
| <Layout.Padded> | ||
| <Text>Styleguide</Text> |
There was a problem hiding this comment.
Worth moving these into translations files?
There was a problem hiding this comment.
I think the styleguide may be more trouble than it’s worth, as it’s not user facing 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.