Optional routers #10
Merged
Optional routers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigcoles
reviewed
Jul 28, 2017
generators/base/index.js
Outdated
| @@ -193,10 +275,11 @@ module.exports = class extends Generator { | |||
| } | |||
|
|
|||
| install() { | |||
| return; | |||
There was a problem hiding this comment.
I know this is WIP, but can we make sure this gets removed. Install event won't fire otherwise. Removed it locally for now as you might of put it in there for a reason 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now lets the you choose whether you’d like
react-navigationorreact-native-router-flux(capped to3.41.0).It also includes a fix for exporting sagas, which seems to be an odd error with Babel at the moment.
Also, fixes #9