update test suite to using SOAP messages#20
Merged
monkeyiq merged 4 commits intosimplesamlphp:masterfrom Sep 24, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #20 +/- ##
============================================
- Coverage 76.38% 75.91% -0.48%
+ Complexity 21 20 -1
============================================
Files 1 1
Lines 144 137 -7
============================================
- Hits 110 104 -6
+ Misses 34 33 -1 🚀 New features to boost your workflow:
|
Member
|
I think it's perfect @monkeyiq ! |
Contributor
Author
|
It seems that maybe the phpstan issues that are left were already there? Both would be dealing with an |
Contributor
Author
|
The type of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure this is a complete update. The AttributeQuery came from the base64 decoded, deflated example contained in the original QUERY_STRING.
It might be an idea at some stage to include an
AuthnRequestmessage. Though that sort of thing might be better focused into the main SSP test suite. Adding some more SOAP round trips there and verifying thesamlp:Response.Closes #17