Skip to content

update test suite to using SOAP messages#20

Merged
monkeyiq merged 4 commits intosimplesamlphp:masterfrom
monkeyiq:2025/sep/soap-update
Sep 24, 2025
Merged

update test suite to using SOAP messages#20
monkeyiq merged 4 commits intosimplesamlphp:masterfrom
monkeyiq:2025/sep/soap-update

Conversation

@monkeyiq
Copy link
Contributor

@monkeyiq monkeyiq commented Sep 24, 2025

I am not sure this is a complete update. The AttributeQuery came from the base64 decoded, deflated example contained in the original QUERY_STRING.

It might be an idea at some stage to include an AuthnRequest message. Though that sort of thing might be better focused into the main SSP test suite. Adding some more SOAP round trips there and verifying the samlp:Response.

Closes #17

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.91%. Comparing base (991e3c9) to head (1881c5f).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     76.38%   75.91%   -0.48%     
+ Complexity       21       20       -1     
============================================
  Files             1        1              
  Lines           144      137       -7     
============================================
- Hits            110      104       -6     
+ Misses           34       33       -1     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tvdijen
Copy link
Member

tvdijen commented Sep 24, 2025

I think it's perfect @monkeyiq !

@monkeyiq
Copy link
Contributor Author

It seems that maybe the phpstan issues that are left were already there? Both would be dealing with an AbstractMessage?

    public function receive(ServerRequestInterface $request): AbstractMessage

@monkeyiq monkeyiq merged commit 2270807 into simplesamlphp:master Sep 24, 2025
21 of 22 checks passed
@monkeyiq
Copy link
Contributor Author

The type of $message is AttributeQuery from the call:

   $message = $soap->receive($request);

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rewrite to use asynchronous binding

2 participants