Skip to content

Fix for #121 - missing Sensor::init() calls and NRF52 support by Polyphe #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 31, 2021

Conversation

runger1101001
Copy link
Member

No description provided.

@runger1101001 runger1101001 changed the title Fix for #121 - missing Sensor::init() calls Fix for #121 - missing Sensor::init() calls and NRF52 support by Polyphe Oct 31, 2021
@askuric
Copy link
Member

askuric commented Oct 31, 2021

Hey Richard,
I've tested the code and I'd like to merge it, I've got just one question. Should this samd code be merged also?

@runger1101001
Copy link
Member Author

Yes, I think it can be merged. It makes the AREF pin optional in SAMD current sensing, so you can use the internal reference if you can't spare the AREF pin or don't want to use it.
It should be ok to merge, the SAMD current sensing isn't quite working for me yet anyway, so I don't think it makes things worse :-)

Sorry it got mixed in with the other changes, but it was already on my dev branch when I merged the latest release to my branch...

@askuric askuric merged commit 396cffd into simplefoc:dev Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants