Skip to content

Feat hybridstepper to main - #55

Merged
runger1101001 merged 1 commit into
devfrom
feat_hybridstepper_to_main
Mar 12, 2025
Merged

runger1101001 merged 1 commit into
devfrom
feat_hybridstepper_to_main

Conversation

@askuric

@askuric askuric commented Mar 12, 2025

Copy link
Copy Markdown
Member

Provided that we move the HybridStepperClass to main this class in the drivers can either be removed or renamed. Here I've renamed it to HybridStepperMotorOld - it is not 100% the same as the one in the PR simplefoc/Arduino-FOC#457.
As it does not implement the current sensing and still has the issue with the space vector calculation explained here: https://community.simplefoc.com/t/driving-two-phase-bilpolar-steppers-with-three-phase-bldc-driver-hybrid-stepper-motor/5043

@runger1101001

Copy link
Copy Markdown
Member

We should merge the other PR first as this one also includes those changes from the calibrated sensor.

If the HybridStepper moves to main library, then I guess it’s better to remove it completely here.

@runger1101001

Copy link
Copy Markdown
Member

Hmm even after merging the other PR this one still shows all the same changes… whereas I think we want only the last commit from this PR, actually.

If it’s ok I’ll just make a new commit where I remove the old HybridStepper - I’ll leave the folder and point to the new functionality in its ReadMe

@askuric

askuric commented Mar 12, 2025

Copy link
Copy Markdown
Member Author

Yeah sure, go for it, I'm in for removing it.
I'm not sure why there are still some differences. There should not be any really. I'll look into it late.

@askuric
askuric changed the base branch from dev to feat_stepper_calib March 12, 2025 16:37
@askuric
askuric changed the base branch from feat_stepper_calib to dev March 12, 2025 16:37
@askuric

askuric commented Mar 12, 2025

Copy link
Copy Markdown
Member Author

Ok I've rebased it and it is ok now.

So yeah, if you want you can also just remove it and discard this PR.

@runger1101001
runger1101001 merged commit 05f458e into dev Mar 12, 2025
@runger1101001

Copy link
Copy Markdown
Member

I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants