Adding support for MA735 #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1.0.7 PR
This is largely based off of the code for MA730, with some additional functions to support the variable resolution and speed. The MA735 is probably one of the cheapest Mag Alpha sensors out there.
Member
|
Thank you so much for contributing this! I don't have this sensor to test myself, but am happy to merge it based on your successful tests. I have changed the PR to be against the dev branch of the library, we only accept PRs to dev. Just running the test compiles, and assuming it compiles for all our platforms I will merge it. Thanks again! |
Contributor
Author
|
Interesting the esp32 platform failed to compile. It seems unrelated to my code though. |
Member
|
Yes, that's not a problem - the esp32 upgrade is already on the dev branch of SimpleFOC so this error will be fixed with the next SimpleFOC release. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely based off of the code for MA730, with some additional functions to support the variable resolution and speed (Tied to the Filter Window register). The MA735 is probably one of the cheapest Mag Alpha sensors out there, and looks like a really nice option from my testing. Resolution is inversely proportional to reading speed, ranging from 9-13 bit resolution and 64uS to 16 ms update times.