-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feature flags #5117
Merged
Merged
Remove feature flags #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msasikanth
approved these changes
Nov 13, 2024
Set to true in config parameter, pivoted to all users
set to true for all users in config file.
set to true for all users in config file.
set to true for all users in config file.
set to true for all users in config file
set to true for all users
set to true for all users
msasikanth
force-pushed
the
siddharth-agarwal/sc-13936
branch
from
November 13, 2024 03:43
fe5042b
to
cca1712
Compare
msasikanth
reviewed
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Before we merge this in, confirm from Bola once about enabling these options by default now and see if there is something that we aren't 100% sure about, just to be safe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove feature flag that were not present in the firebase config parameters file:
Remove feature flags that are pivoted to 100% of users: