Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple-server failures in CI #5116

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

igbanam
Copy link
Contributor

@igbanam igbanam commented Nov 12, 2024

Story: https://app.shortcut.com/simpledotorg/story/13775/fix-integration-tests-on-android-ci-checks

This PR is exploratory in nature. In order to fix CI, we need to test what's wrong in CI. This PR serves as both probe and antidote. The steps taken to fix the CI is documented in the commits below.

p.s: the first commit is to allow Github create a PR

This reverts commit e1595f0.

…in an attempt to fix this

```
remote:  !     Could not detect rake tasks
remote:  !     ensure you can run `$ bundle exec rake -P` against your app
remote:  !     and using the production group of your Gemfile.
remote:  !     rake aborted!
```

RAILS_ENV is "test", but RACK_ENV is "production".
This reverts commit 17f7f54.

Didn't fix the problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant