Rebase: Fix at_exit hook to cooperate with Minitest #855
Conversation
PragTob
force-pushed
the
fix-at-exit-hook
branch
from
66d74ee
to
a3ec24d
Compare
|
@adam12 if you get to try this out to see if I didn't accidentally break the fix I'd be very happy :) But the feature works so I hope for the best 🤞 |
|
Looks great. I'm going to give it a try sometime this week. I never could figure out why the coverage changed on #756 between Ruby versions. |
|
@adam12 ah I squashed all the commits, basically in the Let me know what you find once you try it out 🤞 And thanks for your help with this 💚 |
|
@adam12 👋 Do you know if you'll get to trying this out? No pressure, would just be nice since you had the initial problems. I'm looking to merge it some time this week. |
PragTob
force-pushed
the
fix-at-exit-hook
branch
from
a3ec24d
to
f23f3fb
Compare
Looks to be functioning correctly here. At least to say, I get coverage report at the end of the test run and not immediately before the tests start running as was happening previously. |
|
@adam12 thanks for trying it out! Will merge 😁 |
PragTob
force-pushed
the
fix-at-exit-hook
branch
from
f23f3fb
to
074f505
Compare
| @@ -189,6 +189,14 @@ def exit_status_from_exception | |||
| end | |||
| end | |||
|
|
|||
| def at_exit_behvior | |||
There was a problem hiding this comment.
good catch, thank you!
Update ruby-simplecov to 0.18.5. 0.18.5 (2020-02-25) =================== Can you guess? Another bugfix release! ## Bugfixes * minitest won't crash if SimpleCov isn't loaded - aka don't execute SimpleCov code in the minitest plugin if SimpleCov isn't loaded. Thanks to [@edariedl](https://github.com/edariedl) for the report of the peculiar problem in [#877](simplecov-ruby/simplecov#877). 0.18.4 (2020-02-24) =================== Another small bugfix release 🙈 Fixes SimpleCov running with rspec-rails, which was broken due to our fixed minitest integration. ## Bugfixes * SimpleCov will run again correctly when used with rspec-rails. The excellent bug report [#873](simplecov-ruby/simplecov#873) by [@odlp](https://github.com/odlp) perfectly details what went wrong. Thanks to [@adam12](https://github.com/adam12) for the fix [#874](simplecov-ruby/simplecov#874). 0.18.3 (2020-02-23) =========== Small bugfix release. It's especially recommended to upgrade simplecov-html as well because of bugs in the 0.12.0 release. ## Bugfixes * Fix a regression related to file encodings as special characters were missing. Furthermore we now respect the magic `# encoding: ...` comment and read files in the right encoding. Thanks ([@Tietew](https://github.com/Tietew)) - see [#866](simplecov-ruby/simplecov#866) * Use `Minitest.after_run` hook to trigger post-run hooks if `Minitest` is present. See [#756](simplecov-ruby/simplecov#756) and [#855](simplecov-ruby/simplecov#855) thanks ([@adam12](https://github.com/adam12)) 0.18.2 (2020-02-12) =================== Small release just to allow you to use the new simplecov-html. ## Enhancements * Relax simplecov-html requirement so that you're able to use [0.12.0](https://github.com/colszowka/simplecov-html/blob/master/CHANGELOG.md#0120-2020-02-12)
This is me trying to resurrect #756