Pluggable parallel-test-runner adapter interface#1195
Merged
Conversation
Coordination with parallel test runners (picking the "final" worker,
waiting for siblings, knowing how many resultsets to expect) used to
hard-code the parallel_tests gem. Env-var-only runners like
parallel_rspec hit the wrong branch of `final_result_process?` and every
worker thought it was the final one. They clobbered each other's
resultsets.
Introduce `SimpleCov::ParallelAdapters`, a small registry and selection
layer with a four-method contract (`active?`, `first_worker?`,
`wait_for_siblings`, `expected_worker_count`). `ParallelTestsAdapter`
wraps the historical gem API. `GenericAdapter` handles the env-var
convention without needing any specific gem. Adapters are tried in
registration order, and the first whose `active?` returns true is
chosen. parallel_rspec works out of the box, and users with custom
runners can plug in their own adapter via:
SimpleCov::ParallelAdapters.register MyAdapter
Resolves #1065.
sferik
force-pushed
the
parallel-adapter-interface
branch
from
8a4ab08 to
1144923
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordination with parallel test runners (picking the "final" worker, waiting for siblings, knowing how many resultsets to expect) used to hard-code the parallel_tests gem. Env-var-only runners like parallel_rspec hit the wrong branch of
final_result_process?and every worker thought it was the final one. They clobbered each other's resultsets.Introduce
SimpleCov::ParallelAdapters, a small registry and selection layer with a four-method contract (active?,first_worker?,wait_for_siblings,expected_worker_count).ParallelTestsAdapterwraps the historical gem API.GenericAdapterhandles the env-var convention without needing any specific gem. Adapters are tried in registration order, and the first whoseactive?returns true is chosen. parallel_rspec works out of the box, and users with custom runners can plug in their own adapter via: