Skip to content

Do not ask for reviews after every alias creations when run on macOS #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntnhon merged 1 commit into from
Sep 6, 2023
Merged

Do not ask for reviews after every alias creations when run on macOS #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions SimpleLogin/SimpleLogin/Modules/Main/MainView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,11 +121,10 @@ struct MainView: View {
if let scene = UIApplication.shared
.connectedScenes
.first(where: { $0.activationState == .foregroundActive }) as? UIWindowScene {
switch UIDevice.current.userInterfaceIdiom {
case .phone, .pad:
if !ProcessInfo.processInfo.isiOSAppOnMac {
// Only ask for reviews when not in macOS because macOS doesn't respect
// the 3 time per year limit so users are prompted after every alias creations
SKStoreReviewController.requestReview(in: scene)
default:
break
}
}
}
Expand Down